feat: Add SymCache Transformers (NATIVE-463) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 68.62% 68.85% +0.22%
==========================================
Files 83 84 +1
Lines 17365 17472 +107
==========================================
+ Hits 11917 12030 +113
+ Misses 5448 5442 -6 |
Swatinem
commented
Feb 2, 2022
Swatinem
changed the title
flub
reviewed
Feb 4, 2022
These allow transforming the function and source location records that will be written into SymCaches.
Swatinem
force-pushed
the
feat/transform-symcache
branch
from
732694a
to
3e2cd11
Compare
loewenheim
reviewed
Feb 23, 2022
Comment on lines
-70
to
+88
| fn insert_string(&mut self, s: &str) -> u32 { | ||
| fn insert_string( | ||
| string_bytes: &mut Vec<u8>, | ||
| strings: &mut HashMap<String, u32>, | ||
| s: &str, | ||
| ) -> u32 { |
There was a problem hiding this comment.
I assume this is some sort of borrow checker dance?
There was a problem hiding this comment.
yup, since I can’t borrow all of self :-(
loewenheim
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow transforming the function and source location records that
will be written into SymCaches.
fixes #422