ref: Turn minidump processor (breakpad) into optional feature (NATIVE-524) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 68.71% 68.73% +0.01%
==========================================
Files 84 84
Lines 17506 17506
==========================================
+ Hits 12030 12032 +2
+ Misses 5476 5474 -2 |
loewenheim
approved these changes
Mar 18, 2022
| @@ -29,9 +29,13 @@ include = [ | |||
| [package.metadata.docs.rs] | |||
| all-features = true | |||
|
|
|||
| [features] | |||
| default = ["processor"] | |||
There was a problem hiding this comment.
I would prefer a feature name that makes the dependency on breakpad clearer. Maybe breakpad-processor or something like that.
There was a problem hiding this comment.
I originally wanted to just name the feature breakpad. But that is essentially opaque. We don’t have a second processor implementation in symbolic, so turning off breakpad, you turn off the whole processor. And that is also in line with symbolicator, since it won’t be using the symbolic crate as processor anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature flag makes it possible to avoid building and linking breakpad code.