Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only skip one fn when encountering unknown Unwind Codes on Win-x64 #588

Merged
merged 1 commit into from
May 30, 2022

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented May 30, 2022

Actually there was a comment above the match explaining the intent, but it did not match the actual code.

@Swatinem Swatinem requested a review from a team May 30, 2022 12:08
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #588 (0c3f5ea) into master (fc8db82) will increase coverage by 0.10%.
The diff coverage is 75.00%.

❗ Current head 0c3f5ea differs from pull request most recent head ccf4a59. Consider uploading reports for the commit ccf4a59 to get more accurate results

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   66.85%   66.96%   +0.10%     
==========================================
  Files         101      101              
  Lines       18885    18885              
==========================================
+ Hits        12626    12646      +20     
+ Misses       6259     6239      -20     

@Swatinem Swatinem merged commit 8c9eabc into master May 30, 2022
@Swatinem Swatinem deleted the fix/skip-win-fn branch May 30, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants