fix(debuginfo): include more pdb symbols #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking symbol.function, check whether the symbol is contained in an executable section. This matches what pdb-addr2line does, and is closer to what dump_syms' handwritten PDB parsing does. This change allows more symbols to be included. For example, it allows the following symbols from basic-opt32.pdb to pass the check: ``` 4f9d7 _rtinfpopse 4f9d9 _rtinfnpopse 4f9e9 _fFLN 4fa9e _rtinfpop 4faa0 _rtinfnpop 4fabd _ffexpm1 ``` https://github.com/mozilla/dump_syms/blob/54f9e6240e34cf17fc7dc60ac4985772e2c20001/test_data/windows/basic-opt32.pdb These symbols have symbol.function == false, so they were being filtered out before. The change also adds over 300 symbols for ntdll.pdb BD298DA990CD4BF9BE5CE4796D7924C61. The handwritten PDB parsing in dump_syms currently uses this full check: `symbol.function || symbol.code || is_in_executable_section || is_in_executable_section_contribution` This seems like overkill; I've tested a few pdbs and haven't found any for which this additional complexity would make a difference.
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
+ Coverage 71.20% 71.25% +0.04%
==========================================
Files 96 96
Lines 18408 18433 +25
==========================================
+ Hits 13108 13134 +26
+ Misses 5300 5299 -1 |
Swatinem
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking symbol.function, check whether the symbol is contained
in an executable section. This matches what pdb-addr2line does, and is
closer to what dump_syms' handwritten PDB parsing does.
This change allows more symbols to be included. For example, it allows the
following symbols from basic-opt32.pdb to pass the check:
https://github.com/mozilla/dump_syms/blob/54f9e6240e34cf17fc7dc60ac4985772e2c20001/test_data/windows/basic-opt32.pdb
These symbols have symbol.function == false, so they were being filtered
out before.
The change also adds over 300 symbols for ntdll.pdb BD298DA990CD4BF9BE5CE4796D7924C61.
The handwritten PDB parsing in dump_syms currently uses this full check:
symbol.function || symbol.code || is_in_executable_section || is_in_executable_section_contributionThis seems like overkill; I've tested a few pdbs and haven't found any
for which this additional complexity would make a difference.