ref: Improve _sigtramp workaround and explanation #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for our _sigtramp workaround is lack of support for DWARF expressions. This fact is documented in more detail, and the hand-crafted ASCII CFI is extended to all the call preserved (callee saves) registers.
loewenheim
approved these changes
Aug 17, 2022
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Sep 14, 2022
This includes the following fixes: - Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676)) - Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662)) - Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Sep 14, 2022
This includes the following fixes: - Correctly resolve the `DW_AT_producer` attribute of DWARF files ([#676](getsentry/symbolic#676)) - Improve _sigtramp workaround and explanation ([#662](getsentry/symbolic#662)) - Slightly lower demangling recursion limit ([#655](getsentry/symbolic#655))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for our _sigtramp workaround is lack of support for DWARF expressions.
This fact is documented in more detail, and the hand-crafted ASCII CFI is extended to
all the call preserved (callee saves) registers.