fix: Be more lenient parsing Abbreviations #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent fix for Abbreviations parsing might have been too overeager and may cause EOF errors in case there are no Abbreviations (at offset 0) at all.
ashwoods
approved these changes
Sep 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 73.37% 73.36% -0.02%
==========================================
Files 84 84
Lines 17681 17682 +1
==========================================
- Hits 12974 12972 -2
- Misses 4707 4710 +3 |
loewenheim
approved these changes
Sep 16, 2022
|
For visibility: I think the underlying problem might have caused an increase in https://sentry.my.sentry.io/organizations/sentry/issues/311736/?project=5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent fix for Abbreviations parsing might have been too overeager and may cause EOF errors in case there are no Abbreviations (at offset 0) at all.