feat: Add new sourcemapcache subcrate and python bindings
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Metro/Hermes SourceMaps have scopes embedded in them which we now prefer. In that case, we can completely skip parsing and extracting scopes from the minified JS.
* fix(sourcemapcache): Handle files with no name * ref(sourcemapcache): Use token.get_src_id directly for sl.file_idx * ref(sourcemapcache): Remove redundant str/bytes decoding in py bindings Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 73.11% 73.24% +0.12%
==========================================
Files 84 91 +7
Lines 17526 18304 +778
==========================================
+ Hits 12814 13406 +592
- Misses 4712 4898 +186 |
kamilogorek
approved these changes
Sep 23, 2022
Swatinem
commented
Sep 23, 2022
Swatinem
commented
Sep 23, 2022
Comment on lines
+94
to
+97
| let mut buffer = Vec::new(); | ||
| writer.serialize(&mut buffer)?; | ||
|
|
||
| let byteview = ByteView::from_vec(buffer); |
There was a problem hiding this comment.
This holds the sourcemapcache buffer in memory. Not sure its worth putting in the API to write it to disk, and to read/map it from disk right now. But we should think about that rather sooner than later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new subcrate offers functionality to build a fast lookup index for resolving minified JS line/column to their original line/column/file and function name using information extracted from a provided minified source and its corresponding sourcemap.
This functionality is also exposed via the symbolic python API to be used by the sentry monolith, see getsentry/sentry#38551