feat(debuginfo): Add inlinee overlap checks. #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes getsentry#713. In the FunctionBuilder, which is used for the DWARF reader and for the breakpad reader, we were already splitting lines which were extending beyond the end of an inlinee. Now we also split lines which extend into the beginning of the next inlinee. This fixes all "overlapping line" warnings in the debuginfo_debug example when run on the macos/crash.dSYM. Those overlapping lines were caused by "self lines" which overlapped with "inlinee lines". I've also updated crash.inlines.sym with a file that I freshly generated using a dump_syms build which includes this symbolic fix. Now the crash.inlines.sym file no longer has overlapping inlinees.
This commit adds a few checks to the debuginfo_debug example: We now check that the lines from sibling inlinees don't overlap with each other. This is another failure case which is currently happening in practice, namely in the breakpad reader, and it's confusing the symcache writer. I will fix the breakpad reader in a different PR.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 72.35% 72.07% -0.28%
==========================================
Files 93 93
Lines 18513 18621 +108
==========================================
+ Hits 13395 13422 +27
- Misses 5118 5199 +81 |
Swatinem
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a few checks to the debuginfo_debug example: We now check that the lines from sibling inlinees don't overlap with each other.
This is another failure case which is currently happening in practice, namely in the breakpad reader, and it's confusing the symcache writer. I will fix the breakpad reader in a different PR.