Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debuginfo): Ensure proper inlinee nesting. #720

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mstange
Copy link
Contributor

@mstange mstange commented Nov 25, 2022

Fixes #719.

@mstange mstange requested a review from a team November 25, 2022 23:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #720 (75d91a5) into master (b7131bd) will decrease coverage by 0.23%.
The diff coverage is 56.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   72.35%   72.11%   -0.24%     
==========================================
  Files          93       93              
  Lines       18513    18706     +193     
==========================================
+ Hits        13395    13490      +95     
- Misses       5118     5216      +98     

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for the detailed comments and explanations!

Needs a rebase as all the predecessor PRs were merged.

symbolic-debuginfo/src/function_builder.rs Outdated Show resolved Hide resolved
symbolic-debuginfo/src/function_builder.rs Outdated Show resolved Hide resolved
@mstange
Copy link
Contributor Author

mstange commented Nov 28, 2022

I would be very interested in a release, after this lands.

@Swatinem Swatinem merged commit d595fcd into getsentry:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The breakpad reader doesn't split merged inlinees
3 participants