Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recognize PPDB files as has_sources() even though it only has links #774

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Mar 22, 2023

To enable symbolicator using these files to resolve source context.

@vaind vaind requested a review from a team March 22, 2023 15:40
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #774 (303e2bc) into master (6d730f0) will increase coverage by 0.01%.
The diff coverage is 90.00%.

❗ Current head 303e2bc differs from pull request most recent head 9f3eb7e. Consider uploading reports for the commit 9f3eb7e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   74.67%   74.68%   +0.01%     
==========================================
  Files          71       71              
  Lines       15400    15407       +7     
==========================================
+ Hits        11500    11507       +7     
  Misses       3900     3900              

@vaind vaind merged commit b757c00 into master Mar 23, 2023
@vaind vaind deleted the fix/ppdb-source-links-only branch March 23, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants