fix: increase IL2CPPP source mapping boundary #776
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 74.70% 74.99% +0.29%
==========================================
Files 71 71
Lines 15416 15561 +145
==========================================
+ Hits 11516 11670 +154
+ Misses 3900 3891 -9 |
vaind
changed the title
vaind
force-pushed
the
fix/il2cpp-mapping
branch
from
4f7777d
to
4658d31
Compare
| let cpp_lines = cpp_source.split('\n').collect::<Vec<_>>(); | ||
| let clean_cpp_lines = cpp_lines | ||
| .iter() | ||
| .map(|line| line.split_once('|').unwrap().0.trim_end()) |
There was a problem hiding this comment.
there is also rsplit_once here and below.
There was a problem hiding this comment.
on a second look, I've restructured this part. It came together iteratively and could have been written cleaner, so I did that now.
| assert_eq!(parsed_mapping.lookup("main.cpp", 5), Some(("main.cs", 17))); | ||
| assert_eq!(parsed_mapping.lookup("main.cpp", 12), None); | ||
| assert_eq!(parsed_mapping.lookup("main.cpp", 6), Some(("main.cs", 17))); |
There was a problem hiding this comment.
this might be a bit overkill here to enumerate every line. the important one I guess is that 12 now has a mapping.
There was a problem hiding this comment.
it may be but it also makes the expectation clear (and removes the guesswork) so if you don't mind I'd keep it there for each line
vaind
force-pushed
the
fix/il2cpp-mapping
branch
3 times, most recently
from
f25e915
to
0e2ac01
Compare
vaind
force-pushed
the
fix/il2cpp-mapping
branch
from
0e2ac01
to
d1dcd4e
Compare
In response to getsentry/sentry-unity#1239 and after manually sampling through some generated source files, this PR increases the boundary on the lines that are considered matching. From what I've seen so far, it should not increase false positive matches (significantly) but it should provide much better result for actual code that often spans ~30 lines for a block of
source_infocomments.Closes getsentry/sentry-unity#1239