Optimze SourceBundle/DebugSession #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives each `SourceBundleDebugSession` its own `archive`, so multiple sessions do not contend on the same lock. Also creates the manifest index eagerly and shares that across debug sessions. While previously the complete `SourceBundle` was cached in memory and shared, each `DebugSession` would still create its own index on each access. Another driveby improvement is to provide a consuming `SourceFileDescriptor::into_contents` to avoid a clone.
loewenheim
approved these changes
May 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 74.99% 74.98% -0.01%
==========================================
Files 71 71
Lines 15570 15585 +15
==========================================
+ Hits 11676 11687 +11
- Misses 3894 3898 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives each
SourceBundleDebugSessionits ownarchive, so multiple sessions do not contend on the same lock. Also creates the manifest index eagerly and shares that across debug sessions. While previously the completeSourceBundlewas cached in memory and shared, eachDebugSessionwould still create its own index on each access. Another driveby improvement is to provide a consumingSourceFileDescriptor::into_contentsto avoid a clone.