Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: add some mypy typing to symbolic #797

Merged
merged 1 commit into from
Jun 26, 2023
Merged

ref: add some mypy typing to symbolic #797

merged 1 commit into from
Jun 26, 2023

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry marked this pull request as ready for review June 26, 2023 13:38
Swatinem
Swatinem approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

I’m wondering how much of this we would get for free if we used something like pyo3 or similar…

@asottile-sentry asottile-sentry merged commit b79788d into master Jun 26, 2023
11 checks passed
@asottile-sentry asottile-sentry deleted the mypy branch June 26, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

@loewenheim loewenheim loewenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asottile-sentry @Swatinem @loewenheim