ref(download): Improve configurability of HostDenyList
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c3cbed.
Swatinem
approved these changes
Mar 11, 2024
anonrig
reviewed
Mar 11, 2024
| /// | ||
| /// The host deny list temporarily blocks symbol sources when | ||
| /// they cause too many download failures in a given timespan. | ||
| pub deny_list_enable: bool, |
There was a problem hiding this comment.
Nit
Suggested change
| pub deny_list_enable: bool, | |
| pub deny_list_enabled: bool, |
anonrig
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two fundamental changes to the
HostDenyList.deny_list_enabledtofalse(default istrueso everything keeps working as before).deny_list_never_block_hosts(defaults to[]).