ref(proguard): Keep track of frame indices #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Mar 20, 2024
anonrig
reviewed
Mar 20, 2024
| /// | ||
| /// When returning frames in a `CompletedJvmSymbolicationResponse`, all frames that were | ||
| /// expanded from the frame with index `i` will also have index `i`. | ||
| pub index: usize, |
There was a problem hiding this comment.
This feels like an offset rather than an index, but I'm fine with both.
anonrig
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolication can expand one raw JVM frame into multiple frames. When we return the symbolicated stacktraces, we want it to be possible to tell which symbolicated frames came from which raw frames. To this end, we add an index to frames that you need to pass in and that gets copied to the symbolicated frames.
Example: You send a stacktrace to Symbolicator containing frames with indices
[0, 1, 3, 4](frame2has been filtered out for one reason or another). Symbolicator expands frame3to 3 frames. Then you'll get back frames with indices[0, 1, 3, 3, 3, 4].