ref(proguard): Increase in-memory cache size to 5GiB #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
We should keep this in mind once we start rolling this out to single tenant, as those symbolicator instances are running with a lot less memory allocation.
One more reason to only run a single symbolicator (pool) instead of splitting between JS/JVM/LPQ in ST, as that is both unnecessary, and even contraproductive in this case.
And I have advocated against doing so since the very beginning, but I guess noone listens to me 🤷🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our preliminary tests with 50% load, we saw in-memory cache hit rate settle at about 50%. Thus, we increase the in-memory cache size so more proguard mappers can be kept in memory.
Further increases may follow if in-memory hit rate is still not satisfactory.