ref(wasm-split): Simplify varint encoding prefix #621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Follow-up to #619.
I wasn't quite sure at the time how to reuse the LEB128 / varint encoding prefix from the
wasmbin
library. It turns out that it is easy to do with the Encode trait.The library has some basic encoding support for builtin types. Strings get encoded as binary contents, and binary contents (RawBlob) automatically get encoded with the length before the contents, and the length integer gets encoded as a LEB128 / varint.
Tested by comparing the emscripten output with the wasm-split flag.
PTAL @Swatinem