feat: Add support for Portable PDB debug files / caches and .NET symboliction #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 70.28% // Head: 70.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/upd-deps #883 +/- ##
====================================================
+ Coverage 70.28% 70.72% +0.43%
====================================================
Files 58 59 +1
Lines 11311 11621 +310
====================================================
+ Hits 7950 8219 +269
- Misses 3361 3402 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Swatinem
reviewed
Sep 29, 2022
crates/symbolicator/src/services/symbolication/symbolication.rs
Outdated
Show resolved
Hide resolved
This does a `cargo update`, pulling in a new symbolic and reqwest. The updated symbolic contains a new symcache version that now uses a LEB128-prefixed string table. The patched reqwest was also updated to the latest upstream code.
loewenheim
force-pushed
the
feat/symbolicate-dotnet
branch
from
eb31e84
to
76c3afc
Compare
Swatinem
reviewed
Oct 5, 2022
| image_addr: "0x0" | ||
| candidates: | ||
| - source: local | ||
| location: "http://localhost:<port>/download/integration.pdb/0C1033F78632492E91C6C314B72E1920e60b819d/integration.pdb" |
There was a problem hiding this comment.
NOTE to self: not sure if we should FF out the age right away, or leave it for later.
| index: usize, | ||
| ) -> Result<Vec<SymbolicatedFrame>, FrameStatus> { | ||
| tracing::trace!("Loading symcache"); | ||
| let symcache = match symcache.parse() { |
There was a problem hiding this comment.
I’m just now realizing that we are loading these cache files over and over again for each frame. Not a problem for now, but an opportunity for improvement later on.
There was a problem hiding this comment.
It also happens in several different places.
crates/symbolicator/src/services/symbolication/symbolication.rs
Outdated
Show resolved
Hide resolved
crates/symbolicator/src/services/symbolication/symbolication.rs
Outdated
Show resolved
Hide resolved
|
The RFC regarding extension of the protocol is here: getsentry/rfcs#13 |
Swatinem
changed the title
Swatinem
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for Portable PDB files, namely fetching them from sentry and external symbol sources as well converting those to appropriate cache files.
This also implements .NET event symbolication based on the new Event properties specified in RFC 0013.
Depends on getsentry/symbolic#696.