Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding implementation for apply_on_update #4

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

IanWoodard
Copy link
Member

Updating sh.cd, our json utils, and adding the implementation for apply_on_update.

@IanWoodard IanWoodard requested a review from a user December 4, 2023 22:41
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only low priority stuff. you're good to merge without any of that, I think?
Probably should correct the typing though.

lib/sh.py Outdated Show resolved Hide resolved
manual_tests/behaviors/apply_on_update.py Outdated Show resolved Hide resolved
@IanWoodard IanWoodard merged commit ea1d00d into main Dec 5, 2023
@bukzor bukzor deleted the iw/apply-on-update branch January 19, 2024 23:36
kneeyo1 added a commit that referenced this pull request Apr 11, 2024
# This is the 1st commit message:

debugging

# This is the commit message #2:

debugging

# This is the commit message #3:

debugging

# This is the commit message #4:

proper json encoding

# This is the commit message #5:

convert list to json string

# This is the commit message #6:

trying this out instead of all slices

# This is the commit message #7:

pipe in all the slices first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant