Add parameter to "slash run" for forcing/forbidden console colors

[ayalash]

Logbook supports forbidden/forcing log colors: since getlogbook/logbook#239

slash run should support it too.

[ayalash]

As far as I know, there are too conventions for it:

• Example from grep man page:

--color[=WHEN], --colour[=WHEN]
    ... WHEN is never, always, or auto.

• Example from ag man page:

--[no]color
    Print color codes in results. Enabled by default.

[vmalloc]

@ayalash I prefer the first convention

[ayalash]

@vmalloc You preferred that I use grep like convention, but I just remembered that we have --force-color and --no-color flags to slash list and slash list-config. Shouldn't we have the same convention for all sub-commands? Should I change list and list-config to use --color[=WHEN] as well?

[vmalloc]

Yup. We should

…

On Wed, 12 Jul 2017 at 13:22 Ayala Shachar ***@***.***> wrote: @vmalloc <https://github.com/vmalloc> You preferred that I use grep like convention, but I just remembered that we have --force-color and --no-color flags to slash list and slash list-config. Shouldn't we have the same convention for all sub-commands? Should I change list and list-config to use --color[=WHEN] as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#635 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABwJhXwcQb1ys-Cob4xkIF4VQwsbLYHks5sNJ5EgaJpZM4OVZiS> .

[ayalash]

@vmalloc Should I support the "old" flags (for list commands) with deprecation, or should I just change them to the new ones?

[vmalloc]

@ayalash I meant to align the new ones according to the old ones, not the other way around. The old ones seem reasonable as well, so no big deal

[ayalash]

oh, ok... I'm happy I asked :)

[ayalash]

@vmalloc Can you please release a version of Logbook?
This issue should depend on the code you merged on getlogbook/logbook#239.

[vmalloc]

Released 1.1.0. Will be on Pypi soon