Read file as binary #982
Merged
Read file as binary #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid encoding errors when files are in different encodings
Codecov Report
@@ Coverage Diff @@
## develop #982 +/- ##
===========================================
+ Coverage 93.11% 93.11% +<.01%
===========================================
Files 83 84 +1
Lines 6765 6784 +19
===========================================
+ Hits 6299 6317 +18
- Misses 466 467 +1
Continue to review full report at Codecov.
|
|
Thanks for the PR! |
vmalloc
previously approved these changes
Oct 23, 2019
|
One small request - can you please add a changelog entry for this change? |
|
sure thing |
vmalloc
approved these changes
Oct 23, 2019
|
Many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid decoding errors when files are in different encodings