Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable CGO #12

Merged
merged 1 commit into from Mar 25, 2023
Merged

Conversation

nabeken
Copy link
Contributor

@nabeken nabeken commented Mar 11, 2023

Hello,

I'm testing the release binary with Lambda Function and got the following error:

/var/task/ecs-drain-lambda: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /var/task/ecs-drain-lambda)
/var/task/ecs-drain-lambda: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /var/task/ecs-drain-lambda)
2023/03/11 05:37:25 exit status 1

It seems like the build environment is too new compared to the lambda runtime environment (Amazon Linux 1). I think the binary doesn't require CGO so disabling it would be a simple solution.

@nabeken
Copy link
Contributor Author

nabeken commented Mar 22, 2023

@trane9991 gentle reminder when you have time 😄

@taraspos
Copy link
Member

Hey, @nabeken did you have a chance to run and test it without CGO enabled?

Copy link
Member

@taraspos taraspos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think disabling CGO should be a good idea, however, it would be nice to try to run it in the actual environment, before pushing it to the mainline.

@nabeken
Copy link
Contributor Author

nabeken commented Mar 23, 2023

@trane9991 yes, I did the test with the binary built with my fork at https://github.com/nabeken/ecs-drain-lambda/releases/tag/v1.0.6-nabeken and it worked well.

@taraspos taraspos merged commit 713bbcd into getsocial-rnd:master Mar 25, 2023
3 checks passed
@taraspos
Copy link
Member

Released in v1.0.7. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants