-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
- Loading branch information
1 parent
ccfa24d
commit 62f75a9
Showing
4 changed files
with
58 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
From 7c4e1357e49baebdd2d20710fccb5604cbb36c0d Mon Sep 17 00:00:00 2001 | ||
From: Fabian Kosmale <fabian.kosmale@qt.io> | ||
Date: Thu, 18 Apr 2024 10:25:21 +0200 | ||
Subject: [PATCH] QStringConverterICU: Pass correct pointer to callback | ||
MIME-Version: 1.0 | ||
Content-Type: text/plain; charset=UTF-8 | ||
Content-Transfer-Encoding: 8bit | ||
|
||
Pass the pointer to the current state, not a pointer to a pointer to it. | ||
|
||
[ChangeLog][QtCore][QStringConverter] Fixed a bug involving moved | ||
QStringEncoder/QStringDecoder objects accessing invalid state. | ||
|
||
Amends 122270d6bea164e6df4357f4d4d77aacfa430470. | ||
|
||
Done-with: Marc Mutz <marc.mutz@qt.io> | ||
Pick-to: 6.5 | ||
Change-Id: I70d4dc00e3e0db6cad964579662bcf6d185a4c34 | ||
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> | ||
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io> | ||
(cherry picked from commit 39bbfce9b675c9085ef49c9b9c52c146eca55e4a) | ||
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | ||
--- | ||
src/corelib/text/qstringconverter.cpp | 4 +- | ||
.../qstringconverter/tst_qstringconverter.cpp | 72 +++++++++++-------- | ||
2 files changed, 44 insertions(+), 32 deletions(-) | ||
|
||
diff --git a/src/corelib/text/qstringconverter.cpp b/src/corelib/text/qstringconverter.cpp | ||
index b5749843917..fd45ccf2fdd 100644 | ||
--- a/src/corelib/text/qstringconverter.cpp | ||
+++ b/src/corelib/text/qstringconverter.cpp | ||
@@ -1954,7 +1954,7 @@ struct QStringConverterICU : QStringConverter | ||
const void *context; | ||
ucnv_getToUCallBack(icu_conv, &action, &context); | ||
if (context != state) | ||
- ucnv_setToUCallBack(icu_conv, action, &state, nullptr, nullptr, &err); | ||
+ ucnv_setToUCallBack(icu_conv, action, state, nullptr, nullptr, &err); | ||
|
||
ucnv_toUnicode(icu_conv, &target, targetLimit, &source, sourceLimit, nullptr, flush, &err); | ||
// We did reserve enough space: | ||
@@ -1987,7 +1987,7 @@ struct QStringConverterICU : QStringConverter | ||
const void *context; | ||
ucnv_getFromUCallBack(icu_conv, &action, &context); | ||
if (context != state) | ||
- ucnv_setFromUCallBack(icu_conv, action, &state, nullptr, nullptr, &err); | ||
+ ucnv_setFromUCallBack(icu_conv, action, state, nullptr, nullptr, &err); | ||
|
||
ucnv_fromUnicode(icu_conv, &target, targetLimit, &source, sourceLimit, nullptr, flush, &err); | ||
// We did reserve enough space: | ||
-- | ||
GitLab | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
0001-Support-stateless-config-directories.patch | ||
qt6-base-cflags.patch | ||
qt6-base-nostrip.patch | ||
CVE-2024-33861.patch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters