Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapd: Add confinement warning #3211

Merged
merged 1 commit into from
Jul 11, 2024
Merged

snapd: Add confinement warning #3211

merged 1 commit into from
Jul 11, 2024
+56 −8

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Jul 3, 2024

Summary

Add a warning when starting snap applications. The warning is shown on the CLI when invoking snap there, and as a notification when starting a GUI application.

Test Plan

Run a snap command on the CLI:

afbeelding

Run a GUI application:

afbeelding

Checklist

  • Package was built and tested against unstable

@ermo
Copy link
Contributor

ermo commented Jul 3, 2024

Looks promising!

@silkeh silkeh force-pushed the snap-confinement-warning branch 2 times, most recently from 8c9631e to 588c64e Compare July 10, 2024 14:21
@silkeh
Copy link
Member Author

silkeh commented Jul 10, 2024

I updated the script with two things:

  • A check for strict confinement. This means that no warning will be shown on LTS for the time being.
  • A command-line option to disable the warning.

Updated output:

image

image

I'll PR the help center page later today!

@silkeh silkeh marked this pull request as ready for review July 10, 2024 14:22
@silkeh silkeh mentioned this pull request Jul 10, 2024
Merged
1 task
@silkeh silkeh mentioned this pull request Jul 10, 2024
Open
ermo
ermo previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things worked for me as-is.

I have only added a few nits that you may or may not wish to address.

packages/s/snapd/files/wrapper.sh Show resolved Hide resolved
packages/s/snapd/files/wrapper.sh Outdated Show resolved Hide resolved
packages/s/snapd/files/wrapper.sh Outdated Show resolved Hide resolved
@silkeh
snapd: Add confinement warning
75ebac7 
**Summary**

Add a warning when starting snap applications. The warning is shown on the CLI when invoking `snap` there, and as a notification when starting a GUI application.
@silkeh silkeh requested a review from ermo July 11, 2024 19:12
ermo
ermo approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silkeh silkeh merged commit 5c35c7e into main Jul 11, 2024
1 check passed
@silkeh silkeh deleted the snap-confinement-warning branch July 11, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silkeh @ermo