Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: switch to asterisk bolding to fix SC changelogs #366

Merged
merged 1 commit into from Sep 22, 2023

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Sep 22, 2023

Summary

Switches the PR template to asterisk bolding instead of H2. The (current) Software Center has no support for rendering H2 and this makes changelogs look worse (IMO at least)

H2:

Asterisk bolding:

Test Plan

Looked at changelogs with asterisk bolding and H2 formatting in SC and compared.

Checklist

  • Package was built and tested against unstable

Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
Copy link
Contributor

@ReillyBrogan ReillyBrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@ReillyBrogan ReillyBrogan merged commit 1de7b35 into getsolus:main Sep 22, 2023
@Staudey Staudey deleted the pr-template branch September 22, 2023 22:50
GZGavinZhao pushed a commit to GZGavinZhao/packages that referenced this pull request Sep 27, 2023
…s#366)

## Summary

Switches the PR template to asterisk bolding instead of H2. The
(current) Software Center has no support for rendering H2 and this makes
changelogs look worse (IMO at least)

H2:
![](https://i.imgur.com/Uqax8lA.png)

Asterisk bolding:
![](https://i.imgur.com/tMQ9lrj.png)

## Test Plan

Looked at changelogs with asterisk bolding and H2 formatting in SC and
compared.

## Checklist

- [x] Package was built and tested against unstable

Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants