Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-software: Initial inclusion at 45.3 #428

Merged
merged 1 commit into from Jan 22, 2024
Merged

gnome-software: Initial inclusion at 45.3 #428

merged 1 commit into from Jan 22, 2024

Conversation

joebonrichie
Copy link
Contributor

@joebonrichie joebonrichie commented Oct 2, 2023 •
edited

Summary

Initial gnome-software package for testing viability of using packagekit and gnome-sofware/discover.

Test Plan

  • Install, update and, remove flatpaks
  • Upgrade system
  • Install & remove packages from solus origin (packagekit)
  • Add and remove repos
  • Search for packages

To-Do

  • Avoid reboot requirement once --only-download support is implemented
  • See if we can show all pkgs, not just those with appstream support
  • Improve packaging in relevant packages where appstream is iffy (e.g. libadwaita showing as Adwaita Demo)

Checklist

  • Package was built and tested against unstable

@joebonrichie joebonrichie changed the title gnome-software: Initial inclusion at 44.5 gnome-software: Initial inclusion at 45.0 Oct 18, 2023
@EbonJaeger
Copy link
Member

It looks like automatic updating is enabled by default. We should probably change that.

@joebonrichie
Copy link
Contributor Author

joebonrichie commented Oct 26, 2023 •
edited

It looks like automatic updating is enabled by default. We should probably change that.

https://gitlab.gnome.org/GNOME/gnome-software/-/commit/46eca30b6786b66af9c8eeac1f64f1ffdd6fbc0b

10 years ago :( I know of a hack we can do to get online updates working but the text presented to the user doesn't match up e.g. Still shows up as "Needs Restart" and "Download" instead of install.

I'm looking at forcing the GS_APP_STATE_UPDATABLE_LIVE quirk in the G-S packagekit backend to get back online updates.

@EbonJaeger
Copy link
Member

I'm confused. Does that mean the top option does nothing, or...?
image

@joebonrichie
Copy link
Contributor Author

I'm confused. Does that mean the top option does nothing, or...?

I'm sorry I completely misread your message! You're right we should turn that off by default

@joebonrichie joebonrichie changed the title gnome-software: Initial inclusion at 45.0 gnome-software: Initial inclusion at 45.1 Oct 26, 2023
@EbonJaeger
Copy link
Member

Just installed updates from both the Solus repo and Flathub, and everything seems to have worked correctly. 😃

@EbonJaeger
Copy link
Member

Removing software does not work because I do not have permission. Might need some polkit integration work.

@ReillyBrogan
Copy link
Contributor

Removing software does not work because I do not have permission. Might need some polkit integration work.

Maybe this in packagekit?

@joebonrichie
Copy link
Contributor Author

Removing software does not work because I do not have permission. Might need some polkit integration work.

Resolved with #620

@joebonrichie joebonrichie force-pushed the gnome-software branch 2 times, most recently from 983f7f9 to 50f9c1f Compare November 16, 2023 16:30
@joebonrichie joebonrichie force-pushed the gnome-software branch 3 times, most recently from 3ccc3d8 to 6982342 Compare January 22, 2024 00:35
@joebonrichie joebonrichie changed the title gnome-software: Initial inclusion at 45.1 gnome-software: Initial inclusion at 45.3 Jan 22, 2024
@joebonrichie joebonrichie marked this pull request as ready for review January 22, 2024 00:36
ermo
ermo approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly harmless. Let's merge it and see what gives.

@joebonrichie joebonrichie merged commit f36b8fd into main Jan 22, 2024
1 check passed
@joebonrichie joebonrichie deleted the gnome-software branch January 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joebonrichie @EbonJaeger @ReillyBrogan @ermo