Revert intro of WithError for most key sources
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
changed the title
hiddeco
changed the title
WithError for most key sources
Most of the rewritten key sources introduced `WithError` calls, which does not appear to go well with the UX of the CLI. This reverts it to be the semi equal to current `master`. During the diff, I noticed the current age implementation in master does make use of `WithError`. Which makes me wonder if errors are not returned twice at present in the CLI. Signed-off-by: Hidde Beydals <hello@hidde.co>
onedr0p
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to start to move things fromThis PR addresses one issue reported by @ajvb via email.developintomaster.mainversusdevelop, reverting allWithErrorcalls aligns things again to match original UX is the answer.Edge-case backwards compatibility issue for GCP key source, cherry-picked from @ajvb's own https://github.com/mozilla/sops/commits/ajvb/fixes.Point 2 will be handled separately.