Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Correctly tag code as yaml-stream #1350

Merged
merged 1 commit into from
Nov 14, 2023
Merged

README: Correctly tag code as yaml-stream #1350

merged 1 commit into from
Nov 14, 2023

Conversation

felixfontein
Copy link
Contributor

Right now the rstcheck test fails because a YAML stream with two documents is labelled as a YAML file.

@felixfontein
Correctly tag code as yaml-stream
f9d3db5 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein mentioned this pull request Nov 13, 2023
Merged
@felixfontein felixfontein requested a review from a team November 13, 2023 20:02
hiddeco
hiddeco approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably prioritize just making this Markdown to save ourselves from an immense amount of pain (except the automatic ToC generation, that's actually pretty nice).

@felixfontein felixfontein merged commit 0cc1d11 into getsops:main Nov 14, 2023
8 checks passed
@felixfontein felixfontein deleted the readme branch November 14, 2023 05:58
@felixfontein
Copy link
Contributor Author

@hiddeco thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @hiddeco