Move extraction of encryption and rotation options to separate functions #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2023
Merged
felixfontein
force-pushed
the
refactor
branch
from
304598e
to
8e91c4f
Compare
hiddeco
reviewed
Feb 6, 2024
…Shamir threshold, etc.). Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
felixfontein
force-pushed
the
refactor
branch
from
8e91c4f
to
4b61117
Compare
Signed-off-by: Felix Fontein <felix@fontein.de>
|
@hiddeco thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for a rewrite of #1343, which aims at implementing #1333 (Make encrypt, decrypt, rotate, set, and edit proper commands).
This simplifies the main command handler to a more manageable ~180 lines of code, and heavily reduces the copy'n'paste that would happen in an implementation like #1343.
This is #1387 without #974. Once merged I'll update #1387 to contain a version of #974 rebased to the then current
mainbranch.