Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integration tests: reformat test code, make sure exit codes are always checked #1390

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Improve integration tests: reformat test code, make sure exit codes are always checked #1390

merged 3 commits into from
Dec 29, 2023

Conversation

felixfontein
Copy link
Contributor

No description provided.

@felixfontein felixfontein requested a review from a team December 26, 2023 16:18
This was referenced Dec 26, 2023
Merged
Merged
devstein
devstein approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. What you think about adding a CI check to enforce rustfmt? Happy to make an issue for tracking

@felixfontein
Run cargo fmt.
d6804fe 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Test more status codes.
2290395 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Change double command (--encrypt --set) to single command (--set).
2ca6831 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Contributor Author

Adding a CI check definitely makes sense! It's so easy to apply formatting (simply run cargo fmt) if you remember you have to do it...

@felixfontein felixfontein merged commit cc0477c into getsops:main Dec 29, 2023
9 checks passed
@felixfontein felixfontein deleted the tests branch December 29, 2023 21:17
@felixfontein felixfontein mentioned this pull request Dec 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @devstein