Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close tmpfile after writing #685

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Close tmpfile after writing #685

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5af0913
Close tmpfile after writing
lbonanomi Jun 28, 2020
836ad33
Update cmd/sops/edit.go
lbonanomi Jul 6, 2020
675367c
defer edited file close
lbonanomi Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/sops/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ func editTree(opts editOpts, tree *sops.Tree, dataKey []byte) ([]byte, error) {
if err != nil {
return nil, common.NewExitError(fmt.Sprintf("Could not write output file: %s", err), codes.CouldNotWriteOutputFile)
}

// Close temporary file, since Windows won't delete the file unless it's closed beforehand
defer tmpfile.Close()

// Compute file hash to detect if the file has been edited
origHash, err := hashFile(tmpfile.Name())
Expand Down