Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing super.init in AsyncOperation #3045

Closed
dongfanger2018 opened this issue Feb 27, 2024 · 2 comments · Fixed by #3046
Closed

Missing super.init in AsyncOperation #3045

dongfanger2018 opened this issue Feb 27, 2024 · 2 comments · Fixed by #3046

Comments

@dongfanger2018
Copy link

What did you do?

i don't know whether is's a bug or not
it seems you missing call super.init() in AsyncOperation

What did you expect to happen?

add super.init

What happened instead?

don't know

GetStream Environment

**GetStream Chat version:4.46.0
GetStream Chat frameworks: StreamChat, StreamChatUI
iOS version:
Swift version:
Xcode version:
Device:

Additional context

AsyncOperation is a subclass of nsobject, you should call super.init

image

@nuno-vieira
Copy link
Member

nuno-vieira commented Feb 27, 2024

Hello,

This is not a bug. Calling super.init in this case has no impact.

Best,
Nuno

@nuno-vieira
Copy link
Member

Hi @dongfanger2018,

Update: We are going to change this either way. Even tho it should have no impact, the docs say that it is recommended to call super.init in NSOperations, here: https://developer.apple.com/documentation/foundation/nsoperation/1808546-init

So we will update it anyways 👍

Best,
Nuno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants