Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package JSON is being bundled in the JavaScript dist code #549

Closed
Buzzertech opened this issue May 11, 2023 · 1 comment
Closed

Package JSON is being bundled in the JavaScript dist code #549

Buzzertech opened this issue May 11, 2023 · 1 comment

Comments

@Buzzertech
Copy link

Buzzertech commented May 11, 2023

Context

We have noticed that this library ships about 3kb of it's package.json content with it's dist code

Current behaviour

The culprit seems to be this import inside client.ts where the pkg is being imported to retrieve the library version which is used here.

Expected behaviour

You could inject the version string at build time by using webpack's DefinePlugin.

@xernobyl
Copy link
Contributor

Thank you for the input. We're deploying a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants