Fixed regexp backtracking problem in footnote definitions and codeblocks

Fixes #256
gettalong · Jul 1, 2015 · 2574208 · 2574208
1 parent c37e128
commit 2574208
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 1 deletion.
diff --git a/lib/kramdown/parser/kramdown/blank_line.rb b/lib/kramdown/parser/kramdown/blank_line.rb
@@ -11,7 +11,7 @@ module Kramdown
   module Parser
     class Kramdown
 
-      BLANK_LINE = /(?:^\s*\n)+/
+      BLANK_LINE = /(?>^\s*\n)+/
 
       # Parse the blank line at the current postition.
       def parse_blank_line

diff --git a/test/testcases/span/04_footnote/regexp_problem.html b/test/testcases/span/04_footnote/regexp_problem.html
@@ -0,0 +1,14 @@
+<h1>Something</h1>
+<p>something<sup id="fnref:note1"><a href="#fn:note1" class="footnote">1</a></sup>.</p>
+
+<h1>Footnotes</h1>
+
+<h1>Test</h1>
+<div class="footnotes">
+  <ol>
+    <li id="fn:note1">
+
+      <p>A note <a href="#fnref:note1" class="reversefootnote">&#8617;</a></p>
+    </li>
+  </ol>
+</div>
diff --git a/test/testcases/span/04_footnote/regexp_problem.text b/test/testcases/span/04_footnote/regexp_problem.text
@@ -0,0 +1,52 @@
+# Something
+something[^note1].
+
+# Footnotes
+[^note1]:
+    A note
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+# Test