New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser crashes if empty tag is found in table cell when html_to_native option is enabled #514
Comments
PR available. See #515. |
Thank you for the bug report and fix! |
I'm glad to help! Thanks for reviewing and merging, @gettalong! |
@gettalong would you be willing to do a patch release that includes this fix? I'm processing a large number of Markdown documents and this bug is being triggered, which is preventing the conversion from running to completion. Thanks! |
I'm in the process of going through all commits and issues/pull request since the last release - release will be today or in the next few days. |
Thanks @gettalong! I really appreciate it. |
If the html_to_native option is enabled, and an empty tag is found in a table cell, the parser crashes because the value of the node is nil.
Here's a test case:
The error occurs in Table#parse_table
A simple nil check will fix the problem. I also recommend using a string instead of a regexp to split.
I'd be happy to submit a PR to correct this problem.
The text was updated successfully, but these errors were encountered: