Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition object properties #80

Merged
merged 2 commits into from
May 17, 2023
Merged

fix definition object properties #80

merged 2 commits into from
May 17, 2023

Conversation

thecomalley
Copy link
Contributor

Pull Request Template

Description

This PR fixes the issue preventing policy objects to be passed into the definition module (rather than loading from a file), this is useful for when Terraform generates the policy definition eg using templatefile()

Fixes #79

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tested example in modules/definition/README.md under "You will also be able to supply object properties at runtime such as:"
  • added use case to examples/definitions.tf to be tested during actions

Test Configuration:

  • Module Version: 2.8.0
  • Terraform Version: v1.4.6
  • AzureRM Provider Version: v3.56.0

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@gettek gettek merged commit d61b536 into gettek:main May 17, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supply object properties at runtime broken
2 participants