Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar tag gets deselected, view resets to "All Tasks" when dragging a child (subtask) onto another task in "Open" tasks view mode #1017

Closed
nekohayo opened this issue Feb 27, 2024 · 0 comments · Fixed by #1095
Closed

Sidebar tag gets deselected, view resets to "All Tasks" when dragging a child (subtask) onto another task in "Open" tasks view mode #1017

nekohayo opened this issue Feb 27, 2024 · 0 comments · Fixed by #1095
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:high regression Essential features that recently broke reproducible-in-git Issues that affect the current dev version
Milestone
0.7: "Getting thi...

Comments

@nekohayo
Copy link
Member

nekohayo commented Feb 27, 2024 •
edited

Since the GTK4 port,

If you currently have:

  • a (sub)tag selected in the sidebar,
  • have the "Open" tasks view selected

...and drag a subtask onto another (to make it a child)...

...then the view will be reset to "All tasks" (it will deselect the tag).

This video shows the issue with the default dataset, in addition to a nastier issue where you can eventually make it freeze/hang (issue #1018):

GTG-GTK4-reparenting-deselects-sidebar-tag-and-eventually-hangs.webm
@nekohayo nekohayo added bug priority:high low-hanging-fruit "Easy picks" suitable for new contributors to tackle regression Essential features that recently broke labels Feb 27, 2024
This was referenced Feb 27, 2024
Open
Merged
@nekohayo nekohayo added the reproducible-in-git Issues that affect the current dev version label Feb 27, 2024
gycsaba96 added a commit to gycsaba96/gtg that referenced this issue Apr 30, 2024
@gycsaba96
Create a dummy button in the sidebar.
dcb1d6b 
An invisible button catches the focus instead of the
"All Tasks" row. Thanks to this button, unintended view
resets can be avoided when a focused widget is removed.

This fixes GitHub issue getting-things-gnome#1017
@gycsaba96 gycsaba96 mentioned this issue Apr 30, 2024
Merged
diegogangl pushed a commit that referenced this issue May 1, 2024
@gycsaba96 @diegogangl
Create a dummy button in the sidebar.
dc0eb1a 
An invisible button catches the focus instead of the
"All Tasks" row. Thanks to this button, unintended view
resets can be avoided when a focused widget is removed.

This fixes GitHub issue #1017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:high regression Essential features that recently broke reproducible-in-git Issues that affect the current dev version
Projects
None yet
Milestone
0.7: "Getting things Gradius — Destro...
Development

Successfully merging a pull request may close this issue.

Create a dummy button in the sidebar gycsaba96/gtg
1 participant
@nekohayo