Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the (deprecated) gtgcli utility's functionality as arguments for the main application #418

Open
esijg opened this issue Jul 13, 2020 · 6 comments
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version

Comments

@esijg
Copy link

esijg commented Jul 13, 2020

The title pretty much says it all. How does one launch gtgcli after installing GTG via flatpak? "flatpak run" doesn't seem to have any listing for gtgcli. Only GTG.

@leio
Copy link
Member

leio commented Jul 13, 2020

There is no gtgcli in 0.4 release at all, not just missing from flatpak.

@esijg
Copy link
Author

esijg commented Jul 13, 2020

ah good to know.
Probably a good idea to get rid of the following statement on the website then as it's a bit misleading.

It even has a command-line control interface (gtgcli), if controlling a GUI with a mouse and keyboard is "too mainstream" for you (⌐■_■) ...if you're hipster-enough to fix this feature, because it's probably broken (otherwise it wouldn't be cutting edge, would it?)

@leio
Copy link
Member

leio commented Jul 13, 2020

Some reincarnation of this is in the future plans somewhere, perhaps related to #277.
We could probably provide such commands as part of the main binary as some desktop actions.
I'm sure help is welcome in code work towards that too :)

In any case, looks like @nekohayo should have a look at this for the website outdatedness

@diegogangl
Copy link
Contributor

diegogangl commented Jul 13, 2020

I can't remember if I put this in a ticket here somewhere, but we should replicate the functionality of gtgcli by adding parameters to gtg itself (now that we can talk to the primary instance thanks to GtkApplication).
Closing since this isn't really a bug.

@nekohayo nekohayo added enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version labels Jul 11, 2021
@nekohayo nekohayo changed the title How to launch gtgcli from terminal when installed via flatpak? Reimplement the (deprecated) gtgcli utility's functionality as arguments for the main application Jul 11, 2021
@nekohayo
Copy link
Member

Reopening as an enhancement/feature request with low-hanging-fruit (assuming it's not so hard that it would mean "patch-or-wont-happen") then, rather than a bug/defect. I'm presuming that it could probably be a fun project for a newcomer to implement. It could maybe even be used as a workaround to solve #643, i.e. users could use GNOME Control Center's ability to bind a keyboard shortcut to running a custom command...

@nekohayo nekohayo reopened this Jul 11, 2021
@nekohayo
Copy link
Member

Wiki page has been slightly updated to at least link to here ;)

I tried finding which commit removed the gtgcli code to reference it here, but didn't find it during my brief search. If @Neui or @diegogangl remembers how it was called as a commit message and can find it, might be worth mentioning here for the record and as potential code inspiration to people looking at this (even if the new approach based on GtkApplication instead of D-Bus would probably mean completely different code, I suppose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version
Projects
None yet
Development

No branches or pull requests

4 participants