Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTK deprecation warnings #68

Closed
shtrom opened this issue Nov 5, 2014 · 3 comments
Closed

GTK deprecation warnings #68

shtrom opened this issue Nov 5, 2014 · 3 comments
Labels
bug priority:medium
Milestone
0.4 "You Are (Not...

Comments

@shtrom
Copy link
Contributor

shtrom commented Nov 5, 2014

With PyGTK-2.24.0 and gtg from commit 1328f1d, I am getting the following warning on startup:

/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkImageMenuItem:use-stock is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkImageMenuItem:always-show-image is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkSettings:gtk-menu-images is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkToolButton:stock-id is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkMisc:xpad is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkImage:stock is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkEntry:secondary-icon-stock is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkImageMenuItem:accel-group is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/browser/browser.py:87: Warning: The property GtkImageMenuItem:image is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.BROWSER_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/editor/calendar.py:46: Warning: The property GtkSettings:gtk-button-images is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.__builder.add_from_file(GnomeConfig.CALENDAR_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/plugins/urgency_color/urgency_color.py:204: Warning: The property GtkAlignment:top-padding is deprecated and shouldn't be used anymore. It will be removed in a future version.
  'preferences.ui'))
/usr/lib/python3.4/site-packages/GTG/plugins/urgency_color/urgency_color.py:204: Warning: The property GtkAlignment:bottom-padding is deprecated and shouldn't be used anymore. It will be removed in a future version.
  'preferences.ui'))
/usr/lib/python3.4/site-packages/GTG/plugins/urgency_color/urgency_color.py:204: Warning: The property GtkAlignment:left-padding is deprecated and shouldn't be used anymore. It will be removed in a future version.
  'preferences.ui'))
/usr/lib/python3.4/site-packages/GTG/gtk/preferences.py:85: Warning: The property GtkMisc:ypad is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ViewConfig.PREFERENCES_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/preferences.py:85: Warning: The property GtkAlignment:yalign is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ViewConfig.PREFERENCES_UI_FILE)
/usr/lib/python3.4/site-packages/GTG/gtk/plugins.py:139: Warning: The property GtkTreeView:rules-hint is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ViewConfig.PLUGINS_UI_FILE)

Then, when I try to edit a task's description, I get an additional warning:

/usr/lib/python3.4/site-packages/GTG/gtk/editor/editor.py:63: Warning: The property GtkContainer:resize-mode is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.builder.add_from_file(GnomeConfig.EDITOR_UI_FILE)

I'm not sure if this is related, but GTG hangs after this warning (though
sending a KeyboardInterrupt with a ^C wakes it up).
@sagarghuge
Copy link
Contributor

I confirmed this Bug, Yes few of the properties are deprecated.

@shtrom shtrom mentioned this issue Mar 7, 2015
Closed
@izidormatusov izidormatusov added this to the 0.4 milestone Mar 15, 2015
@izidormatusov
Copy link
Contributor

Properties that are still in the code even after #144 is merged:

  • use-stock
  • stock-id
  • xpad
  • ypad
  • stock
  • top-padding
  • bottom-padding
  • left-padding
  • xalign
  • yalign
  • rules-hint

deprecated widgets:

  • GtkImageMenuItem
  • GtkAlignment

jakubbrindza added a commit to jakubbrindza/gtg that referenced this issue Jun 30, 2015
@jakubbrindza
Adjustments to Deprecated PR
0fd9222 
This commit goes into depth in removing outdated features and properties such as stock, stock_id, use_stock, etc.
I used checklist in getting-things-gnome#68.
Even though I tried my best, there are 3 problems remaining I'd need a hand with, namely:

* GTG/gtk/browser/CellRendererTags.py
	this file still contains properties xalign, yalign, ypad, xpad which I couldn't resolve
* GTG/gtk/browser/treeview_factory.py
	this file still contains properties xalign, ypad, xpad.
* problem when adding a color in tag editor is not yet resolved as I haven't found adequate replacement
for gtk-color-palette.
/home/jbrindza/gtg/GTG/gtk/browser/simple_color_selector.py:290: Warning: The property GtkSettings:gtk-color-palette is deprecated and shouldn't be used anymore. It will be removed in a future version.
  response = color_dialog.run()
@jakubbrindza jakubbrindza mentioned this issue Jun 30, 2015
Merged
3 tasks
jakubbrindza added a commit to jakubbrindza/gtg that referenced this issue Jul 6, 2015
@jakubbrindza
Adjustments to Deprecated PR
7040657 
This commit goes into depth in removing outdated features and properties such as stock, stock_id, use_stock, etc.
I used checklist in getting-things-gnome#68.

Moreover, I started with moving all the .ui files to a single gtk/ui folder where they will all be placed eventually over the summer as I'm going through the individual parts of GTG.

For now, taskbrowser.ui and modifytags_dialog.ui have been moved to gtk/ui.

Some widgets still accept properties like xalign, yalign, xpad or ypad and are not deprecated for them, therefore I've kept them in the code.
jakubbrindza added a commit to jakubbrindza/gtg that referenced this issue Jul 6, 2015
@jakubbrindza
Adjustments to Deprecated PR
a68ef1b 
This commit goes into depth in removing outdated features and properties such as stock, stock_id, use_stock, etc.
I used checklist in getting-things-gnome#68.

Some widgets still accept properties like xalign, yalign, xpad or ypad and are not deprecated for them, therefore I've kept them in the code.
jakubbrindza added a commit to jakubbrindza/gtg that referenced this issue Jul 6, 2015
@jakubbrindza
Adjustments to Deprecated PR
a5138bc 
This commit goes into depth in removing outdated features and properties such as stock, stock_id, use_stock, etc.
I used checklist in getting-things-gnome#68.

Some widgets still accept properties like xalign, yalign, xpad or ypad and are not deprecated for them, therefore I've kept them in the code.
@jakubbrindza
Copy link
Contributor

None of these issues should be present in the latest dev version of GTG anymore. All of them were resolved in #144 and #155 .

Therefore I believe we can close this bug. If you find something, though, please comment, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority:medium
Projects
None yet
Milestone
0.4 "You Are (Not) Done"
Development

No branches or pull requests
4 participants
@izidormatusov @shtrom @sagarghuge @jakubbrindza