Fix startup errors and style issues #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izidormatusov
force-pushed
the
fix-startup
branch
2 times, most recently
from
305e8f8
to
c3c04a2
Compare
In the newer Gtk (tested on 3.14 that is included in Ubuntu 15.04), there was a slight change in semantics of forward_word_end. If there is a trailing white space, forward_word_end doesn't move to the end of buffer as it is not a word per se, but returns an error (value False).
The following script runs in infinite loop under new Gtk:
```python
from gi.repository import Gtk
buf = Gtk.TextBuffer()
buf.set_text("word ")
it, end = buf.get_bounds()
while (it.get_offset() < end.get_offset()) and (it.get_char() != '\0'):
it.forward_word_end()
prev = it.copy()
prev.backward_word_start()
print('word: "{}"'.format(buf.get_text(prev, it, True)))
```
Fix is to check the return value of it.forward_word_end() in while loop:
```python
while it.forward_word_end():
prev = it.copy()
prev.backward_word_start()
print('word: "{}"'.format(buf.get_text(prev, it, True)))
```
Fixes #90
izidormatusov
force-pushed
the
fix-startup
branch
from
c3c04a2
to
ebe2dc5
Compare
|
Thank you for putting your commit message in a clear way. Now I get why you made the change with forward_word_end(). Everything else seemed reasonable and right to me. |
This was referenced May 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.