merge geolocalized tasks into master #13

elianerpereira · 2014-04-09T23:47:15Z

Parin, who was my mentor during last round of OPW, asked me to do this pull request to merge the geolocalized-tasks plugins into master.

…rkers - doesn't allow the user to delete user location - use a different color to the tag

…s-event LibChamplain does not handle the button-release-event when button-press-event is being treated by geolocalized-tasks, keeping the cursor as a closed hand. If we treat the button-release-event, the behavior is according to what we expect.

…-click menu in the sidebar

…tom menuitems to it There are 2 public methods - add_custom_menuitem() and remove_custom_menuitem() which will be used by plugins for the same

…ck on sidebar menu tag

This reverts commit 5750dfd72d0b393d5de8f355041d29ad532d7b89.

…ht/authors

izidormatusov · 2014-04-10T21:59:12Z

@elianerpereira Can you provide a command that installs all the dependencies on a major distro, e.g. Ubuntu? I would like to try out your work!

parinporecha · 2014-04-15T07:34:07Z

@elianerpereira , I deleted all the tags, still the edit location dialog shows them - http://i.imgur.com/6aSQIIn.png

elianerpereira · 2014-04-15T13:27:15Z

Izidor,

On Thursday, April 10, 2014, Izidor Matušov notifications@github.com
wrote:

@elianerpereira https://github.com/elianerpereira Can you provide a
command that installs all the dependencies on a major distro, e.g. Ubuntu?
I would like to try out your work!

Sorry for the long time to answer you. I am traveling with my husband and
we are without internet in the most places. I will checkout the packages
names and send to you as soon as I have the laptop and the internet.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-40148197
.

Eliane Ramos Pereira

elianerpereira · 2014-04-15T13:29:21Z

Parin,

On Tuesday, April 15, 2014, Parin Porecha notifications@github.com wrote:

@elianerpereira https://github.com/elianerpereira , I deleted all the
tags, still the edit location dialog shows them -
http://i.imgur.com/6aSQIIn.png

Did you clean up your stuff before test it?
I am traveling with Fabiano and we are out of internet here. I will take a
look on the bug as soon as I have the laptop with me and access to internet.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-40453365
.

Eliane Ramos Pereira

elianerpereira · 2014-04-22T09:31:22Z

Izidor,

In addition to the packages needed by GTG, I needed to install:
python3-dbus, running a fedora 20 with gnome 3.12, newly installed.

On Tue, Apr 15, 2014 at 3:27 PM, Eliane Ramos elianerpereira@gmail.comwrote:

Izidor,

On Thursday, April 10, 2014, Izidor Matušov notifications@github.com
wrote:

@elianerpereira https://github.com/elianerpereira Can you provide a
command that installs all the dependencies on a major distro, e.g. Ubuntu?
I would like to try out your work!

Sorry for the long time to answer you. I am traveling with my husband and
we are without internet in the most places. I will checkout the packages
names and send to you as soon as I have the laptop and the internet.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-40148197
.

Eliane Ramos Pereira

Eliane Ramos Pereira

elianerpereira · 2014-04-22T10:43:15Z

Hi Parin,

I'm using an F20, newly installed with gnome 3.12, and tested the behavior
shown by him but was unable to reproduce the bug.
Can you tell me what system you are using, so I can download and install it
on a virtual machine to test?

By the way, I commited a bug that was giving problem with Geoclue yesterday.

On Tue, Apr 15, 2014 at 3:29 PM, Eliane Ramos elianerpereira@gmail.comwrote:

Parin,

On Tuesday, April 15, 2014, Parin Porecha notifications@github.com
wrote:

@elianerpereira https://github.com/elianerpereira , I deleted all the
tags, still the edit location dialog shows them -
http://i.imgur.com/6aSQIIn.png

Did you clean up your stuff before test it?
I am traveling with Fabiano and we are out of internet here. I will take a
look on the bug as soon as I have the laptop with me and access to internet.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-40453365
.

Eliane Ramos Pereira

Eliane Ramos Pereira

NimitS1 · 2014-05-31T06:42:42Z

Hi Elaine,
I am facing this issue while enabling the plugin:
Traceback (most recent call last):
File "/home/limit/projects/gtg/gtg/GTG/gtk/plugins.py", line 261, in on_plugin_toggle
self.pengine.activate_plugins([plugin])
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 217, in activate_plugins
plugin.active = True
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 79, in _set_active
self.instance = self.plugin_class()
File "/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geolocalized_tasks.py", line 72, in init
self.where = Geoclue()
File "/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geoclue.py", line 42, in __init
self.DESKTOP_ID
File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 145, in call
**keywords)
File "/usr/lib/python3/dist-packages/dbus/connection.py", line 651, in call_blocking
message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.InvalidArgs: No such property 'DesktopId'

elianerpereira · 2014-05-31T09:17:01Z

Hello Nimit,

On Sat, May 31, 2014 at 8:42 AM, Nimit Shah notifications@github.com
wrote:

Hi Elaine,
I am facing this issue while enabling the plugin:
Traceback (most recent call last):
File "/home/limit/projects/gtg/gtg/GTG/gtk/plugins.py", line 261, in
on_plugin_toggle
self.pengine.activate_plugins([plugin])
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 217,
in activate_plugins
plugin.active = True
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 79,
in

_set_active self.instance = self.plugin_class() File
"/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geolocalized_tasks.py",
line 72, in init
self.
_where = Geoclue() File
"/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geoclue.py",
line 42, in _init
self.DESKTOP_ID
File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 145, in call
**keywords)
File "/usr/lib/python3/dist-packages/dbus/connection.py", line 651, in
call_blocking
message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.InvalidArgs: No
such property 'DesktopId'

May I ask you to just comment out the lines 39, 40, 41, 42 and 43?
Newer versions of Geoclue asks you to set the Desktop Id property, if I
remember correctly.

What do you suggest as solution? Have a specific (new) version of the

Geoclue as dependency? Try to check the versions?

Eliane Ramos Pereira

parinporecha · 2014-05-31T09:32:56Z

For which distros is the newer version of Geoclue2 released ?

Geoclue2 is fairly new and under active development so API changes are to
be expected.
If you add the code to check versions, it'll have to be updated whenever a
new version is released and it'll also cause maintainability problems.

I think you should add error handling in the code. Check for DBus
exceptions and related, and if caught, show a 'Please mark your position on
the map' infobar message or something like that. The user will have to do
it only once and since we're saving his co-ordinates, it won't happen the
second time onwards.

When the API becomes stable after some time, we'll update the relevant part.

On Sat, May 31, 2014 at 2:47 PM, elianerpereira notifications@github.com
wrote:

Hello Nimit,

On Sat, May 31, 2014 at 8:42 AM, Nimit Shah notifications@github.com
wrote:

Hi Elaine,
I am facing this issue while enabling the plugin:
Traceback (most recent call last):
File "/home/limit/projects/gtg/gtg/GTG/gtk/plugins.py", line 261, in
on_plugin_toggle
self.pengine.activate_plugins([plugin])
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 217,
in activate_plugins
plugin.active = True
File "/home/limit/projects/gtg/gtg/GTG/core/plugins/engine.py", line 79,
in

*set_active self.instance = self.plugin_class() File

"/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geolocalized_tasks.py",
line 72, in _init*
self.

_where = Geoclue() File
"/home/limit/projects/gtg/gtg/GTG/plugins/geolocalized_tasks/geoclue.py",
line 42, in _init
self.DESKTOP_ID
File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 145, in
call

**keywords)
File "/usr/lib/python3/dist-packages/dbus/connection.py", line 651, in
call_blocking
message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.InvalidArgs: No
such property 'DesktopId'

May I ask you to just comment out the lines 39, 40, 41, 42 and 43?
Newer versions of Geoclue asks you to set the Desktop Id property, if I
remember correctly.

What do you suggest as solution? Have a specific (new) version of the

Geoclue as dependency? Try to check the versions?

Eliane Ramos Pereira

—
Reply to this email directly or view it on GitHub
#13 (comment)
.

Regards,
Parin Porecha

elianerpereira · 2014-05-31T12:34:00Z

Hello Parin,

On Sat, May 31, 2014 at 11:32 AM, Parin Porecha notifications@github.com
wrote:

For which distros is the newer version of Geoclue2 released ?

Hmm. I don't know exactly. I made the patch based on the distro I'm using
(Fedora 20 with COPR enabled to use GNOME-3.12)

Geoclue2 is fairly new and under active development so API changes are to
be expected.
If you add the code to check versions, it'll have to be updated whenever a
new version is released and it'll also cause maintainability problems.

I think you should add error handling in the code. Check for DBus
exceptions and related, and if caught, show a 'Please mark your position
on
the map' infobar message or something like that. The user will have to do
it only once and since we're saving his co-ordinates, it won't happen the
second time onwards.

Right. I will do this with the other changes suggested by Nimit (or you, or
who else will review this code).

Eliane Ramos Pereira

izidormatusov · 2015-03-15T22:35:04Z

GTG/plugins/geolocalized_tasks/geoclue.py

+from dbus.mainloop.glib import DBusGMainLoop
+
+
+class Geoclue:


class Geoclue(object):

izidormatusov · 2015-05-23T20:58:04Z

GTG/plugins/geolocalized_tasks/geolocalized_tasks.py

-# to GtkBuilder format together with other glade XMLs.
-# FIXME Since this plugin is broken, I am not going to replace galde mentions
-# to GtkBuilder, it's your job ;)
+FILTER_NAME = '@@GeolocalizedTasks'


 class geolocalizedTasks:


It should inherit from object

diegogangl · 2020-02-09T00:00:40Z

Hi, wasn't this merged at some point? We moved geolocalized tasks into the unmaintained folder. Closing this for now. Thanks for your work though!

elianerpereira and others added 30 commits April 10, 2014 01:26

geolocalized-tasks: Initial rewrite

4be28f6

geolocalized-tasks: Open map with the current location

1b1e602

geolocalized-tasks: Add zoom-in and zoom-out buttons

caf7507

geolocalized-tasks: Split widgets into different .ui files

bd9471c

geolocalized-tasks: Start using glade files

1fea98d

geolocalized-tasks: Cleanup

5db4d20

geolocalized-tasks: Add marker

bc9bef9

geolocalized-tasks: Using ChamplainMapSourceFactory to show map offline

4ef367f

geolocalized-tasks: Enabling option to delete a marker

e4a1c10

geolocalized-tasks: Only show one context menu

9dc8148

geolocalized-tasks: Creating functions to dump/load locations info

7a161d6

geolocalized-tasks: Add/Remove location to/from a task

a50319a

geolocalized-tasks: Save last user location to use it offline

f82e6c3

geolocalized-tasks: Treat the user location differently than other ma…

76dce7a

…rkers - doesn't allow the user to delete user location - use a different color to the tag

geolocalized-tasks: Don't connect the 'button-press-event' twice

df9748e

geolocalized-tasks: Show the location description as its name

45103b9

geolocalized-tasks: Use reverse_async method

73a3869

geolocalized-tasks: Get and print tags

6690a4d

geolocalized-tasks: Show tags on edit menu

c46b3ef

geolocalized-tasks: edit_task.ui

b146b6f

geolocalized-tasks: Relating tags and locations

6a876b1

geolocalized-tasks: Fix the size of the window

5d1975a

geolocalized-tasks: Fix relationship between tags and locations

97979e8

geolocalized-tasks: Change widget on edit_task.ui

79fe396

geolocalized-tasks: Adding the option 'Add location' to a tag's right…

d8afd6c

…-click menu in the sidebar

geolocalized-tasks: Fix change widget on edit_task.ui

853fd3a

Updated tag_context_menu.py so that plugins can now add their own cus…

3aba2f9

…tom menuitems to it There are 2 public methods - add_custom_menuitem() and remove_custom_menuitem() which will be used by plugins for the same

geolocalized-tasks: Callback to open set_task_location from right cli…

fa7c3dc

…ck on sidebar menu tag

geolocalized-tasks: Refactoring tag

437775c

elianerpereira added 11 commits April 10, 2014 01:26

Revert "geolocalized-tasks: Possible fix in bug with tags"

f8a96f4

This reverts commit 5750dfd72d0b393d5de8f355041d29ad532d7b89.

geolocalized-tasks: Use used tags instead of all tags

877f517

geolocalized-tasks: Improve edit dialog when we have only a few tags

a820c5d

geolocalized-tasks: Code's clean-up

a249d94

geolocalized-tasks: Add i18n support

e8cc9c1

geolocalized-tasks: Add Eliane Ramos and Parin Porecha in the copyrig…

9c460b7

…ht/authors

geolocalized-tasks: Remove unused files

bd8befe

geolocalized-tasks: Add plugin dependencies

44f00d5

geolocalized-tasks: Bump version to 0.2.0

08a6cf2

geolocalized-tasks: Adjusting according to pep8

611b8f6

Update CHANGELOG and AUTHORS

b13a32a

geolocalized-tasks: DesktopId property must be set

ceef01d

izidormatusov reviewed Mar 15, 2015
View reviewed changes

izidormatusov added priority:high Pull Request labels Mar 15, 2015

izidormatusov added this to the 0.4 milestone Mar 15, 2015

izidormatusov reviewed May 23, 2015
View reviewed changes

diegogangl mentioned this pull request Dec 4, 2019

Resurrecting this project #210

Closed

diegogangl closed this Feb 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge geolocalized tasks into master #13

merge geolocalized tasks into master #13

elianerpereira commented Apr 9, 2014

izidormatusov commented Apr 10, 2014

parinporecha commented Apr 15, 2014

elianerpereira commented Apr 15, 2014

elianerpereira commented Apr 15, 2014

elianerpereira commented Apr 22, 2014

elianerpereira commented Apr 22, 2014

NimitS1 commented May 31, 2014

elianerpereira commented May 31, 2014

parinporecha commented May 31, 2014

Geoclue as dependency? Try to check the versions?

elianerpereira commented May 31, 2014

izidormatusov Mar 15, 2015

izidormatusov May 23, 2015

diegogangl commented Feb 9, 2020

merge geolocalized tasks into master #13

merge geolocalized tasks into master #13

Conversation

elianerpereira commented Apr 9, 2014

izidormatusov commented Apr 10, 2014

parinporecha commented Apr 15, 2014

elianerpereira commented Apr 15, 2014

elianerpereira commented Apr 15, 2014

elianerpereira commented Apr 22, 2014

elianerpereira commented Apr 22, 2014

NimitS1 commented May 31, 2014

elianerpereira commented May 31, 2014

Geoclue as dependency? Try to check the versions?

parinporecha commented May 31, 2014

Geoclue as dependency? Try to check the versions?

elianerpereira commented May 31, 2014

izidormatusov Mar 15, 2015

Choose a reason for hiding this comment

izidormatusov May 23, 2015

Choose a reason for hiding this comment

diegogangl commented Feb 9, 2020