New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the User Manual for 0.4 #318
Conversation
…tdated Advanced Topics pages, Get Involved pages, and Credits pages; created a new Developer Resources page to house relevant information from the previous mentioned outdated pages; Created a new Preferences topic page; updated images in aforementioned pages; added new folder for outdated pages (status attributes on outdated pages were updated to the outdated tag).
…ed pages for style and clarity, updated deprecated namespace issues and attributes, updated and rewrote Search and Search Syntax pages.
…sks and Managing Tasks section. Edited Create New Task, Delete Task, Dismiss Task, Edit Task, Quick Add (combined previous subpages into main page), Subtasks, and made additional QA edits to previously committed pages.
…cks on previously updated pages. Reviewed for style and consistency.
…ted text. Updated gtg-preferences.page to include Translation and Localization section.
There should now be updates done to |
Hi @leio. I was listing some highlights in the bullets but a number of pages were deleted/updated/combined. I also kept 1 or 2 pages related to sync services in the user manual folder that are not relevant at this moment but could be used in the future. Those items probably shouldn't be added to the build but can remain in the user_manaul folder. It was more in case we needed to add them back into the manual. The deletions were within one of the commits I highlighted but that can be tedious to parse through so I can make the updates to that file, easy enough. Should I add it to this PR so all of this is updated at the same time? Another thing to note, the meson.build piece is a bit over my level but I understand what needs to be done and have no problem updating the file. I think that if this is something that needs to be updated in tandem with any documentation changes to new or deleted files (for example, with a new feature, a new image is added to a page), that should be noted somewhere. While I plan to stay on board and making updates for this project for the foreseeable future, I was thinking about creating some contributor documentation, for updating the user docs. A non-dev contributor may not realize that these pieces need to be updated as well. |
Ideally I think that it would be good if the commit adding or removing a file does the appropriate meson.build updates as well (e.g. commit that removes some pages would include the removal of them in meson.build as well; and additions of pages updates would hook them up in meson in the same commit too). I think the meson bits shouldn't matter beyond just having the list of pages and media up to date, as you can still open it raw with |
I have no issue with the changes in this merge request. I'll admit I've read in a bunch of directions at once and so haven't read "every single word" with extreme attention, but overall it looks great to me. I have a bunch of ideas/suggestions but I threw those into #243 (comment) (and technically this could even be spun into its own ticket, if seen as too intrusive). |
…derstand-gtg-main-window.png.
@nekohayo , as I mentioned in #243 , I am happy to continue making updates to these docs. Just let me know if I should be opening separate issues or continue everything in #243. We will call this one the MVP 0.4 user docs and I will keep improving the docs based on your suggestions (as well as a few that I have noted to myself) in separate requests. It will help to have this request merged so that I can start working in smaller chunks on additional updates without having a long commit history (I have not mastered the interactive rebase yet ;) ). I updated the Pages: Images: These pages/images could be eventually updated and again viable. I didn't think they should be deleted but they are not a part of the build and none of the other .pages refer or link to them. The two videos: These are definitely outdated, but I want to be able to use them as a stretch goal to re-create or do something similar in the future. I know some people learn better with videos. So, if we think that these are still good to have, I can remake at some point in the future. Let me know if there is an issue in keeping anything in the folder that is not in the build. Otherwise, this is good to merge. Thanks again! |
OK there's one last thing that kinda theoretically bugs me and I (unfortunately) hadn't realized before: the commit messages don't follow convention (see https://chris.beams.io/posts/git-commit/, but specifically the part about having a short "subject line", at https://chris.beams.io/posts/git-commit/#limit-50 ) and are therefore not easy to read or to figure out what a particular commit is "essentially about". Currently, the commits's descriptive messages have everything on one single line, and those were of course meant to be a list of things that were changed since I see they were separated by semicolons. Now, I can easily fix/rewrite the messages of your commits to split them across multiple lines, the only problem is that I would still need to have some sort of short descriptive "subject" line for each of them, and I find myself at a loss as to what it could be, and I don't want to denature your work either. @vansia43 would you have an idea of some summary short "subject" for each of those commits that I could put there for you? If you give me such a list (in the order of the commits) then I can pretty easily apply that fix for you. If that's too much work / too annoying to solve post-facto and you don't feel inspired, we can ignore that problem and I can merge as-is, but I do think it is worth having otherwise (especially in the future) because it makes it much clearer for the casual onlooker. If you haven't tried it yet, I can say that the "gitg" app helps a lot with the commit message line lengths, for future commits :) |
@nekohayo Hopefully these are good enough titles. Going further these will be a lot shorter. Let me know if you have any issues with these. Thanks! b433882 db60454 21e00cb 24a05f2 41774ed 05178af 0dc8f69 223c2d1 cec2760 b4fd4eb |
Thank you for this Danielle, I have now taken your proposed titles, adjusted them a little bit (I took some liberties with the extended descriptions too) for length purposes and to explicitly mention "user manual" whenever possible, because as I rebased and pushed your commits, they will appear as fast-forward (i.e. a "straight line of commits"). I considered the fact that some commits renamed/moved files and then deleted them, ideally I would have liked to be able to "cancel out" those changes by squashing them, but since they were tied to other changes I couldn't do that without messing with the history in a significant way. Anyhow. All the changes have now been merged to master. You can now delete or reset your userdocs branch to match the current state of master. To do so, assuming you have no uncommited file changes in your folder:
Normally it should work, I think... the only tricky point is the "origin" remote question, that I'm not sure you have set up in the same way as me. If you are unsure or are encountering trouble, feel free to poke me on IRC and we can even do a desktop screensharing session to get you back up to speed quickly. |
This PR addresses updating the user manual as identified in #243 .
Some highlights to note:
gtg-add-sync.page
andgtg-create-sync.page
) in the folder in case sync services come back. I also leftgtg-create-plugin.page
in the folder but did not include it in the user documentation as I did not think it really belonged in here but wasn't sure if it needed to be added somewhere else.index.page
was reorganized.gtg-tag-color.page
to include requested note about color squares/icons.