App Submission: DCRDEX

[peterzen]

App Submission: DCRDEX

DCRDEX

...

256x256 SVG icon

https://svgshare.com/i/pNb.svg
...

Gallery images

• https://i.imgur.com/dkqCPtJ.png
• https://i.imgur.com/Mc3aTnR.png
• https://i.imgur.com/TFFU0ur.png
  ...

I have tested my app on:

• Umbrel dev environment
• Umbrel OS on a Raspberry Pi 4
• Custom Umbrel install on Linux

[nmfretz]

Sorry for the delay on this @peterzen. Thanks very much for submitting the DCRDEX app. Currently, for crypto-related apps, we're exclusively accepting apps that solely focus on bitcoin for the official Umbrel App Store.

That being said, you can still create a Community App Store to distribute DCRDEX to Umbrel users:
https://github.com/getumbrel/umbrel-community-app-store

I'd be happy to help with this process and can still review the code you have submitted here to make sure DCRDEX runs smoothly on Umbrel.

[peterzen]

Thank you @nmfretz for looking into this app submission. We are currently working on the Community App Store, if you could please review the code that would be much appreciated.

https://github.com/peterzen/umbrel-decred-app-store

Many thanks!

[chappjc]

It might be worth noting that this application provides a neutrino-powered (privacy preserving) Bitcoin wallet, no other dependencies required. It's not a lie to say that despite the name DCRDEX, the application prioritizes it's native BTC wallet.
(DCR or any other coin is not required in any way to use this app, e.g. you can use and swap BTC with LTC)

[nmfretz]

Very high quality PR. Fantastic work @peterzen! I have left some questions and suggested changes. I also took a look at the community app store implementation and everything looks good there.

[nmfretz]

I get a 503 server error when trying to access this SVG. This ends up manifesting on the dashboard as an empty icon image.

[peterzen]

Moved the files into the Github, this should fix the issue.

[nmfretz]

Here I would include an image digest for the multi-arch build. See here for example:

umbrel-apps/mempool/docker-compose.yml

Line 10 in d19f23f

image: mempool/frontend:v2.4.0@sha256:f71722f1e3abfb3d8a3df6f2a32e384d39434e311bb83d810629077b4fa6ffaf

[nmfretz]

Dogecoin is written twice here. much doge. such silly. very duplication.

[peterzen]

Thank you for the review @nmfretz, I've implemented your suggestions in the Community App Store repo which now works correctly.