-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: DCRDEX #430
Conversation
Sorry for the delay on this @peterzen. Thanks very much for submitting the DCRDEX app. Currently, for crypto-related apps, we're exclusively accepting apps that solely focus on bitcoin for the official Umbrel App Store. That being said, you can still create a Community App Store to distribute DCRDEX to Umbrel users: I'd be happy to help with this process and can still review the code you have submitted here to make sure DCRDEX runs smoothly on Umbrel. |
Thank you @nmfretz for looking into this app submission. We are currently working on the Community App Store, if you could please review the code that would be much appreciated. https://github.com/peterzen/umbrel-decred-app-store Many thanks! |
It might be worth noting that this application provides a neutrino-powered (privacy preserving) Bitcoin wallet, no other dependencies required. It's not a lie to say that despite the name DCRDEX, the application prioritizes it's native BTC wallet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very high quality PR. Fantastic work @peterzen! I have left some questions and suggested changes. I also took a look at the community app store implementation and everything looks good there.
repo: https://github.com/decred/dcrdex | ||
support: https://github.com/decred/dcrdex | ||
port: 5758 | ||
icon: https://svgshare.com/i/pNb.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get a 503 server error when trying to access this SVG. This ends up manifesting on the dashboard as an empty icon image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the files into the Github, this should fix the issue.
APP_PORT: 5758 | ||
|
||
web: | ||
image: decred/dcrdex:v0.5.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I would include an image digest for the multi-arch build. See here for example:
umbrel-apps/mempool/docker-compose.yml
Line 10 in d19f23f
image: mempool/frontend:v2.4.0@sha256:f71722f1e3abfb3d8a3df6f2a32e384d39434e311bb83d810629077b4fa6ffaf |
version: "0.5.9" | ||
tagline: Decentralized exchange built by the Decred Project | ||
description: >- | ||
Trade Bitcoin, Decred, Dogecoin, Dogecoin, ZCash and more peer-to-peer using atomic swaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dogecoin is written twice here. much doge. such silly. very duplication.
Thank you for the review @nmfretz, I've implemented your suggestions in the Community App Store repo which now works correctly. |
App Submission: DCRDEX
DCRDEX
...
256x256 SVG icon
https://svgshare.com/i/pNb.svg
...
Gallery images
...
I have tested my app on: