Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Jackett #665

Merged
merged 10 commits into from Oct 13, 2023
Merged

App Submission: Jackett #665

merged 10 commits into from Oct 13, 2023

Conversation

IMPranshu
Copy link
Contributor

@IMPranshu IMPranshu commented Jul 4, 2023

This PR takes care of the issue #487
But additional testing is needed. I think we may need to whitelist something in order to get it completely. Anyways I have no idea need some reviews

App Submission

Jackett

...

256x256 SVG icon

https://raw.githubusercontent.com/IMPranshu/svg-logo/main/jackett.svg
...

Gallery images

jackett-screenshot3
jackett-screenshot2
jackett-screenshot1

...

I have tested my app on:

@IMPranshu IMPranshu marked this pull request as ready for review July 16, 2023 14:49
@nmfretz
Copy link
Contributor

nmfretz commented Aug 4, 2023

I think we may need to whitelist something in order to get it completely. Anyways I have no idea need some reviews

Thanks @IMPranshu, I'll look into this

@nmfretz nmfretz marked this pull request as draft August 16, 2023 23:52
jackett/umbrel-app.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @IMPranshu , It works on umbrel-dev.

There's only one change i've mentioned above otherwise LGTM !

Thanks for the contribution ❤️

@IMPranshu IMPranshu marked this pull request as ready for review September 25, 2023 14:30
Copy link
Contributor

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ParthJadhav
Copy link
Contributor

Hey @IMPranshu, You asked about white listing directories at the start of the PR. Sorry I missed that.

Regarding that:
If you go to this page: https://hub.docker.com/r/linuxserver/jackett/

and look at the docker-compose.yml in the usage section you'll find:

--
version: "2.1"
services:
  jackett:
    image: lscr.io/linuxserver/jackett:latest
    container_name: jackett
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - AUTO_UPDATE=true #optional
      - RUN_OPTS= #optional
    volumes:
      - /path/to/data:/config
      - /path/to/blackhole:/downloads
    ports:
      - 9117:9117
    restart: unless-stopped

Here it's suggested that you mount two volumes:

 volumes:
      - /path/to/data:/config
      - /path/to/blackhole:/downloads

If you want to do it with Umbrel then you will need to mount Umbrel's path:

 volumes:
      - ${APP_DATA_DIR}/data:/config
      - ${APP_DATA_DIR}/blackhole:/downloads

After doing that you would also need to push those directories along with the changes.
To push empty directories you would include .gitkeep file inside the directory.

- jackett 
-- docker-compose.yml
-- umbrel-app.yml
-- data
--- .gitkeep
-- blackhole
--- .gitkeep

@nmfretz
Copy link
Contributor

nmfretz commented Oct 13, 2023

Thanks again for submitting Jackett @IMPranshu. And thanks for your review @ParthJadhav. This is going live to the app store now 🥼.

To bring this to the finish line, we have:

  • changed the port to Jackett's default port (9117) so that users who search for troubleshooting tips online don't need to do any translations
  • bind mounted the blackhole directory to the Umbrel downloads directory on the host
  • added the data directory to this repo to ensure proper ownership/permissions when the app is installed
  • bumped Jackett to the latest version
  • whitelisted the api route in the app proxy
  • added some set up instructions

@nmfretz nmfretz merged commit c08a4bb into getumbrel:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants