New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Jackett #665
Conversation
Thanks @IMPranshu, I'll look into this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @IMPranshu , It works on umbrel-dev
.
There's only one change i've mentioned above otherwise LGTM !
Thanks for the contribution ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Hey @IMPranshu, You asked about white listing directories at the start of the PR. Sorry I missed that. Regarding that: and look at the --
version: "2.1"
services:
jackett:
image: lscr.io/linuxserver/jackett:latest
container_name: jackett
environment:
- PUID=1000
- PGID=1000
- TZ=Etc/UTC
- AUTO_UPDATE=true #optional
- RUN_OPTS= #optional
volumes:
- /path/to/data:/config
- /path/to/blackhole:/downloads
ports:
- 9117:9117
restart: unless-stopped Here it's suggested that you mount two volumes: volumes:
- /path/to/data:/config
- /path/to/blackhole:/downloads If you want to do it with Umbrel then you will need to mount Umbrel's path: volumes:
- ${APP_DATA_DIR}/data:/config
- ${APP_DATA_DIR}/blackhole:/downloads After doing that you would also need to push those directories along with the changes.
|
Thanks again for submitting Jackett @IMPranshu. And thanks for your review @ParthJadhav. This is going live to the app store now 🥼. To bring this to the finish line, we have:
|
This PR takes care of the issue #487
But additional testing is needed. I think we may need to whitelist something in order to get it completely. Anyways I have no idea need some reviews
App Submission
Jackett
...
256x256 SVG icon
https://raw.githubusercontent.com/IMPranshu/svg-logo/main/jackett.svg
...
Gallery images
...
I have tested my app on: