Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: autobrr #731

Merged
merged 3 commits into from Oct 15, 2023
Merged

App Submission: autobrr #731

merged 3 commits into from Oct 15, 2023

Conversation

fabricionaweb
Copy link
Contributor

@fabricionaweb fabricionaweb commented Aug 18, 2023

App Submission

autobrr

autobrr is the modern download automation tool for torrents and usenet

256x256 SVG icon

https://raw.githubusercontent.com/autobrr/autobrr/master/web/src/logo.svg

Gallery images

img-1
img-2

I have tested my app on:

@ParthJadhav
Copy link
Contributor

Also, Feel free to add:

submitter: yourName
submission: thisPrUrl

so that your name is visible on the app store. Example

Copy link
Contributor

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on umbrel-dev server, and it runs properly.
note: didn't test the actual functionality because I didn't understand the app.

Looks good except the optional changes I've mentioned above.

@fabricionaweb
Copy link
Contributor Author

fabricionaweb commented Sep 26, 2023

Thank you very much for the testing! I'll apply the mentioned changes

edit

I made rebase+amend so I needed to push-force.

@ParthJadhav
Copy link
Contributor

Thanks for the Contribution @fabricionaweb ❤️

@nmfretz
Copy link
Contributor

nmfretz commented Oct 13, 2023

Excellent, thank you for this submission @fabricionaweb, we really appreciate it! Tested on both arm64 and x86(amd64). We are just getting the icon and gallery images ready now and will send this to the app store shortly.

FYI, I bumped the version to the recently released v1.31.0 and also renamed the bind mount on the host to ${APP_DATA_DIR}/data purely so that it is consistent with other apps on Umbrel (your way was working just fine).

@nmfretz
Copy link
Contributor

nmfretz commented Oct 15, 2023

Alrighty, icon and gallery images have been added: getumbrel/umbrel-apps-gallery@e32c715. Going live to the app store now 🐇.

Thanks again for all your work on this @fabricionaweb! This is a wonderful addition.

@nmfretz nmfretz merged commit b01f128 into getumbrel:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants