New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Frigate #843
Conversation
Wonderful, thank you @arguser! I will attempt to review this week. |
Hello @nmfretz, do you think we can move this forward? |
Yes, thanks for the ping! I'm working my way up from the earlier submissions and am now here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the submission @arguser!
I don't have a camera to thoroughly test Frigate, so I'll need your help testing as we go back and forth.
I've left a review below. Let me know if anything is unclear. And sorry if I've confused anything, I'm not familiar with Frigate.
frigate/config.yml
Outdated
mqtt: | ||
enabled: False | ||
|
||
cameras: | ||
name_of_your_camera: # <------ Name the camera | ||
ffmpeg: | ||
inputs: | ||
- path: rtsp://10.0.10.10:554/rtsp # <----- The stream you want to use for detection | ||
roles: | ||
- detect | ||
detect: | ||
enabled: False # <---- disable detection until you have a working camera feed | ||
width: 1280 # <---- update for your camera's resolution | ||
height: 720 # <---- update for your camera's resolution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad to see this file can be edited in the app's UI so users don't have to manually do this from the terminal!
Maybe we should note this in the app description and also have one of the gallery images be the config editor screen with text at the top like
Manage your camera configuration within the app
When I quickly look online for frigate install/setup tutorials I see they all show editing this file manually outside of the app so users may be confused.
network_mode: host | ||
restart: unless-stopped | ||
image: ghcr.io/blakeblackshear/frigate:stable@sha256:bb7f7e76a13eccef0b12704e5851cc774a12af1f12df387d6a70a796a3e938c3 | ||
shm_size: "128mb" # update for your cameras based on calculation above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there is a recommended share size that will work for almost everyone? Ideally users should be able to install the app and not have to worry about editing the compose file.
@arguser let me know when you can test with a camera! |
@nmfretz Tested camera, working! Google Coral Edge TPU also working! |
Excellent, thanks @arguser. Are you okay with going live to the app store now? If so, I'll edit the app description slightly to add a bit more detail on configuring a camera and then merge! |
@nmfretz I think we are OK. Would be good to have more flexibility on Reference |
Thanks for looking into this. Let's start with shm_size of 128bm then. We can always modify in an app update if we get user feedback suggesting we should change this value. Thanks again for all your hard work submitting Frigate! Going live to the app store now. |
Actually, @arguser are you able to give me temporary permission to push to your fork so that I can quickly make the final changes? |
@nmfretz done! |
Thanks @arguser! You can now remove my permissions if you'd like. I added some set-up instructions to the app description, made it so that a default deterministic password is shown to the user in the app store for Frigate's RTSP password, and also moved around the file structure a tad so that it is the same as other apps on Umbrel. We're live! |
Co-authored-by: nmfretz <nmfretz@gmail.com>
App Submission
Frigate
256x256 SVG icon
(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)
https://raw.githubusercontent.com/blakeblackshear/frigate/d11c1a20668bca48413fe37895d905b854bc675b/web/images/favicon.svg
Gallery images
(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)
I have tested my app on: