Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Public Pool #915

Merged
merged 10 commits into from Jan 22, 2024
Merged

App Submission: Public Pool #915

merged 10 commits into from Jan 22, 2024

Conversation

smolgrrr
Copy link
Member

App Submission

Public Pool

256x256 SVG icon

https://web.public-pool.io/assets/layout/images/logo.svg

Gallery images

1 2. 2 3. 3

I have tested my app on:

@smolgrrr smolgrrr marked this pull request as draft January 15, 2024 08:13
@smolgrrr
Copy link
Member Author

Fixed proxy issue, and had to fork public-pool-ui to remove some hard-coded stuff so now it works across all domain/IPs :)

@smolgrrr smolgrrr marked this pull request as ready for review January 19, 2024 13:12
Copy link
Contributor

@nmfretz nmfretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @smolgrrr this is great! I've left some minor suggestions. Let's get this shipped 🚀


web:
image: smolgrrr/public-pool-ui:0.1.0@sha256:e219808b92a9f52fc5938860a731d317cf6db1d059af3b982b02b48cbe06dc3b
restart: unless-stopped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can change to on-failure

restart: unless-stopped
stop_grace_period: 30s
ports:
- "0.0.0.0:2018:2018/tcp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove 0.0.0.0: on the host side here since Docker will default to including this.
If you want, you could even remove /tcp and shorten further to just - "2018:2018", but up to you.

ports:
- "0.0.0.0:2018:2018/tcp"
volumes:
- "${APP_DATA_DIR}/data/db/public-pool-db:/public-pool/DB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the db directory to this repo (under the data directory that you have the proxy dir in) and include a .gitkeep within it so that it gets committed to this github repo even when empty.

If you want you can simplify the bind mount to:
- "${APP_DATA_DIR}/data/db:/public-pool/DB"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks missed that

Comment on lines +33 to +34
- API_PORT=2019
- STRATUM_PORT=2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and both these ports are available 👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the stratum server is port 2018, should the first gallery image be changed to reflect that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new
yep definitely


server:
image: sethforprivacy/public-pool:4bb00f2@sha256:0fc82e7123be68650c9e31f57a5a206e622acbcaa170e31219a488818ad6da6b
restart: unless-stopped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can change to on-failure

@@ -0,0 +1,26 @@
manifestVersion: 1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed to 1 since we're not including any hooks

Comment on lines +7 to +11
description: >-
Fully Open Source Solo Bitcoin Mining Pool


Don't trust. Verify. On steroids.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add anything here about connecting a nerdminer, bitaxe, etc? Or just leave as-is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah they've all got their own set-up guides, so i didn't think it would be worth adding. but if anyone reaches out asking what URL to use i could add a little extra to the description.

@smolgrrr smolgrrr merged commit 1cf7bb9 into getumbrel:master Jan 22, 2024
@smolgrrr smolgrrr deleted the public-pool branch January 22, 2024 04:59
@mustafatufan
Copy link

Great news. I was waiting this to be happen. Thanks everyone involved.

@GarmadonGamer
Copy link

GarmadonGamer commented Jan 23, 2024

Great news to now be able to run a solopool on umbrel! but i seem to encounter a problem. As the pool runs the blockheight does not change. Bitcoinnode goes up butt public-pool stays at the blockheigt it started. Where does the worktemplate come from? Looks like the miner run on old work
image
image

@test7813
Copy link

Great news to now be able to run a solopool on umbrel! but i seem to encounter a problem. As the pool runs the blockheight does not change. Bitcoinnode goes up butt public-pool stays at the blockheigt it started. Where does the worktemplate come from? Looks like the miner run on old work image image

same here, blockheight "label" stuck at 82699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants