App Submission: Firefly III Data Importer #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any interest in getting the plaid connector set up for us folks in the US? |
@johnpc thanks for the suggestion! I don't have the capacity at the moment to add it, but I will keep it on my radar. In the meantime please feel free to take a crack at it. Briefly reading the description on gitlab it looks like there would be no easy way for a user to set up the connector through the UI and they'd have to manually add info the their config FYI. |
zapomatic
pushed a commit
to zapomatic/umbrel-apps
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo: https://github.com/firefly-iii/data-importer
Website: https://docs.firefly-iii.org/explanation/data-importer/about/introduction/
I have added this as a separate app instead of including the data importer as a service within the Firefly III compose file. This way there is an obvious way for users to get to the importer app (by installing it and having the app visible on their dashboard). If the importer was a service within the Firefly III compose file, then it would be invisibly running on port 30010 and we would need to provide instructions in the app description on how to access it (e.g., navigate to http://umbrel.local/30010) which isn't great UX.
Tested in production on arm64 and x86.