Auth, wallet unlock separation, container updates #12

mayankchhabra · 2020-05-21T09:23:19Z

Changlog

Remove lnd-unlock container
Add umbrel-manager container
Create directory structure for umbrel-manager
Add umbrel-dashboard container
Update Nginx configuration w.r.t umbrel-manager and umbrel-dashboard

Should be merged after:

umbrel-manager 0.1.0 is released
umbrel-middleware 0.1.0 is released
umbrel-dashboard 0.2.0 is released
Dynamically update JWT public key umbrel-middleware#20 is fixed

Should be tested with:

getumbrel/umbrel-manager:v0.1.0.3
getumbrel/umbrel-middleware:v0.1.0.5
getumbrel/umbrel-dashboard:v0.2.0.3

Closes lncm#9, resolves lncm#10 and fixes lncm#11.

nolim1t · 2020-05-21T09:25:29Z

is this ready to be tested?

nolim1t · 2020-05-21T09:25:48Z

or do we need to release the other versions

nolim1t

LGTM

mayankchhabra · 2020-05-21T09:30:48Z

Not yet, just finishing up other containers. I'll update docker-compose.yml with test versions w.x.y.z for testing once all of them are up

mayankchhabra · 2020-05-21T19:10:40Z

Ok we're ready to test! I've updated docker-compose.yml with the latest w.x.y.z images and will revert back to x.y.z releases after we test it out.

Deployed on https://testnet.getumbrel.com and no issues so far. I'll try it on my hardware node too.

Side note: If you're going to test on an existing umbrel node, don't forget to remove the existing lnd wallet because umbrel-manager will set up a new wallet.

nolim1t · 2020-05-22T09:40:19Z

I get "Unknown authentication strategy \"jwt\""

nolim1t · 2020-05-22T09:40:48Z

versions

CONTAINER ID        IMAGE                               COMMAND                  CREATED             STATUS              PORTS               NAMES
24253f01f7a8        getumbrel/middleware:v0.1.0.4       "docker-entrypoint.s…"   3 hours ago         Up 2 minutes                            umbrel_middleware_1
a01dcacbdfde        lncm/lnd:v0.9.2-root-experimental   "lnd"                    3 hours ago         Up 14 minutes                           umbrel_lnd_1
673c097af1c3        getumbrel/dashboard:v0.2.0.3        "docker-entrypoint.s…"   3 hours ago         Up 14 minutes                           umbrel_dashboard_1
2d81272cc9dd        lncm/bitcoind:v0.19.1               "bitcoind -zmqpubraw…"   3 hours ago         Up 9 minutes                            umbrel_bitcoin_1
7580652ff0c7        nginx:1.17.10                       "nginx -g 'daemon of…"   3 hours ago         Up 10 minutes                           umbrel_web_1
92d86f6e3332        getumbrel/manager:v0.1.0.3          "docker-entrypoint.s…"   3 hours ago         Up 14 minutes                           umbrel_manager_1

nolim1t · 2020-05-22T10:46:00Z

in your docker-compose file you have image: getumbrel/dashboard:v0.2.0.3 defined which I used however the original PR says test with getumbrel/umbrel-dashboard:v0.2.0.2

nolim1t · 2020-05-22T13:38:50Z

getumbrel/umbrel-dashboard:v0.2.0.2 also doesnt work

mayankchhabra · 2020-05-22T15:23:40Z

"Unknown authentication strategy "jwt""

Which container throws that error?

Updated PR comment, should be tested with getumbrel/umbrel-dashboard:v0.2.0.3

nolim1t · 2020-05-23T10:07:33Z

"Unknown authentication strategy "jwt""

Which container throws that error?

Error from browser.. but most likely dashboard container

nolim1t · 2020-05-24T07:13:02Z

Logfile trace from middleware logs after trying to log in

Error: Unknown authentication strategy "jwt"
    at attempt (/usr/src/app/node_modules/passport/lib/middleware/authenticate.js:190:39)
    at authenticate (/usr/src/app/node_modules/passport/lib/middleware/authenticate.js:367:7)
    at jwt (/usr/src/app/middlewares/auth.js:47:5)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:335:12)
    at next (/usr/src/app/node_modules/express/lib/router/index.js:275:10)

Screenshot from dashboard (private browsing window)

nolim1t · 2020-05-24T07:16:12Z

Ok i think I found the issue. I'll retry again

nolim1t · 2020-05-24T07:54:48Z

/v1/lnd/wallet/unlock
NodeError: Invalid JWT
    at /usr/src/app/middlewares/auth.js:38:19
    at allFailed (/usr/src/app/node_modules/passport/lib/middleware/authenticate.js:107:18)
    at attempt (/usr/src/app/node_modules/passport/lib/middleware/authenticate.js:180:28)
    at JwtStrategy.strategy.fail (/usr/src/app/node_modules/passport/lib/middleware/authenticate.js:302:9)
    at /usr/src/app/node_modules/passport-jwt/lib/strategy.js:106:33
    at /usr/src/app/node_modules/jsonwebtoken/verify.js:133:14
    at getSecret (/usr/src/app/node_modules/jsonwebtoken/verify.js:90:14)
    at Object.module.exports [as verify] (/usr/src/app/node_modules/jsonwebtoken/verify.js:94:10)
    at Function.module.exports [as JwtVerifier] (/usr/src/app/node_modules/passport-jwt/lib/verify_jwt.js:4:16)
    at /usr/src/app/node_modules/passport-jwt/lib/strategy.js:104:25

nolim1t · 2020-05-24T09:06:25Z

Ok it seems to be working but have to restart the middleware container every time docker is restarted, which isn't really ideal

nolim1t · 2020-05-24T09:53:33Z

Some changes to the middleware container might be needed

getumbrel/umbrel-middleware#20 (comment)

We will also need to add some HTTP libraries for it to query the manager container

nolim1t · 2020-05-24T15:39:41Z

Pushed a tag with a command we can use in getumbrel/middleware:v0.1.0.5

nolim1t · 2020-05-24T15:50:31Z

Update the docker-compose file with

        middleware:
                image: "getumbrel/middleware:v0.1.0.5"
                command: ["./wait-for-node-manager.sh", "localhost", "npm", "start"]

and this should fix any issues

mayankchhabra · 2020-05-24T16:08:56Z

Great! If you haven't encountered any other issues, then we're ready to merge getumbrel/umbrel-manager#1 and release umbrel-manager 0.1.0.

After that, we can merge getumbrel/umbrel-middleware#21 and release umbrel-middleware 0.1.0.

Then we can proceed to merge getumbrel/umbrel-dashboard#60 and release umbrel-dashboard 0.2.0.

And then finally we'll be ready to merge this current PR #12 lol! 😅

mayankchhabra · 2020-05-27T12:04:50Z

Released

umbrel-manager v0.1.0
umbrel-middleware v0.1.0
umbrel-dashboard v0.2.0

Also deployed the new containers on testnet and everything looks OK.

@nolim1t can you also please test them? If all's OK, we're ready to merge 🚀

nolim1t · 2020-05-28T09:41:47Z

LGTM.. installed on my umbrel box

mayankchhabra · 2020-05-28T11:34:32Z

Ready to rock and roll! We should probably tag this as a v0.1.0 release for umbrel-compose too. What do you think?

mayankchhabra added 2 commits May 21, 2020 14:43

removed lnd-unlock

d904ba3

updated docker compose

b145651

mayankchhabra requested a review from nolim1t May 21, 2020 09:23

nginx

d646edf

nolim1t reviewed May 21, 2020

View reviewed changes

mayankchhabra added 2 commits May 21, 2020 23:30

readme

2165604

ready to test

cac1bce

mayankchhabra marked this pull request as draft May 24, 2020 10:58

nolim1t mentioned this pull request May 24, 2020

Add in checks for docker-compose getumbrel/umbrel-middleware#21

Merged

Add wait-for-node-manager.sh to docker-compose.yml

71b1e9d

mayankchhabra marked this pull request as ready for review May 27, 2020 12:00

Bump to release versions of services

a2da212

mayankchhabra merged commit 8aa86ba into getumbrel:master May 28, 2020

mayankchhabra deleted the auth branch May 28, 2020 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auth, wallet unlock separation, container updates #12

Auth, wallet unlock separation, container updates #12

mayankchhabra commented May 21, 2020 •

edited

Loading

nolim1t commented May 21, 2020

nolim1t commented May 21, 2020

nolim1t left a comment

mayankchhabra commented May 21, 2020

mayankchhabra commented May 21, 2020 •

edited

Loading

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

mayankchhabra commented May 22, 2020 •

edited

Loading

nolim1t commented May 23, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020 •

edited

Loading

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

mayankchhabra commented May 24, 2020 •

edited

Loading

mayankchhabra commented May 27, 2020 •

edited

Loading

nolim1t commented May 28, 2020

mayankchhabra commented May 28, 2020

Auth, wallet unlock separation, container updates #12

Auth, wallet unlock separation, container updates #12

Conversation

mayankchhabra commented May 21, 2020 • edited Loading

Changlog

Should be merged after:

Should be tested with:

nolim1t commented May 21, 2020

nolim1t commented May 21, 2020

nolim1t left a comment

Choose a reason for hiding this comment

mayankchhabra commented May 21, 2020

mayankchhabra commented May 21, 2020 • edited Loading

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

nolim1t commented May 22, 2020

mayankchhabra commented May 22, 2020 • edited Loading

nolim1t commented May 23, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020 • edited Loading

nolim1t commented May 24, 2020

nolim1t commented May 24, 2020

mayankchhabra commented May 24, 2020 • edited Loading

mayankchhabra commented May 27, 2020 • edited Loading

nolim1t commented May 28, 2020

mayankchhabra commented May 28, 2020

mayankchhabra commented May 21, 2020 •

edited

Loading

mayankchhabra commented May 21, 2020 •

edited

Loading

mayankchhabra commented May 22, 2020 •

edited

Loading

nolim1t commented May 24, 2020 •

edited

Loading

mayankchhabra commented May 24, 2020 •

edited

Loading

mayankchhabra commented May 27, 2020 •

edited

Loading